WIP newlib.mk: fix regressions and global cleanups, tracking evolutions of newlib.mk #9512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cladmi
added
State: WIP
cladmi
force-pushed
the
pr/make/newlib/fix_trailing_slash/and/cleanup
branch
from
62eb720
to
9d36929
Compare
|
One of the nice things that should be taken from the fact that nobody really complained that these fixes are needed (except api change), is that the fixes added by #9394 may be fixing everybody case. |
|
I thought about another idea for testing in |
cladmi
force-pushed
the
pr/make/newlib/fix_trailing_slash/and/cleanup
branch
from
454f0e7
to
d1bb8d7
Compare
miri64
added
CI: ready for build
cladmi
added
CI: ready for build
cladmi
force-pushed
the
pr/make/newlib/fix_trailing_slash/and/cleanup
branch
from
d1bb8d7
to
fa7082a
Compare
cladmi
added
the
State: waiting for other PR
This was referenced Aug 2, 2018
cladmi
force-pushed
the
pr/make/newlib/fix_trailing_slash/and/cleanup
branch
from
fa7082a
to
14a8b10
Compare
miri64
added
State: waiting for other PR
and removed
CI: ready for build
This does prevents adding '-isystem' with nothing after which makes the next item in the list `-I/path/RIOT/core/include` considered as an include directory with the '-I' in the path.
cladmi
force-pushed
the
pr/make/newlib/fix_trailing_slash/and/cleanup
branch
from
14a8b10
to
87aba27
Compare
cladmi
added
the
Type: tracking
|
@fjmolinas Do you have this on your radar? |
Not really, I'm not familiar with newlib. I can but it on the todo list, but will not have time for a while. |
|
Ping @fjmolinas |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
WARN: I wanted to re-test commits from this PR after rebasing them multiple times, but could not find time. However I prefer uploading it instead of keeping it local
This started as a PR to fix:
NEWLIB_INCLUDE_DIR-isystem $(empty_variable)to INCLUDESAnd this ended up in also some refactoring, tests.
It is still work in progress
This PR grew quite big and went beyond what I originally planed.
I will split it, refactor and re-organize commits.
I also plan to add parts of #9415 but not the 'nano.specs' this should be kept in the original pr.
I on purpose separated commits to allow adding small parts separately and removing other too problematic ones.
Split PRs
Issues/PRs references
Problems mentioned in #9452