tests/libc_newlib: add test for newlib-nano inclusion [backport 2018.07] #9633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cladmi
added
Process: release backport
cladmi
added
the
State: waiting for other PR
|
It is waiting for #9632 |
cladmi
removed
the
State: waiting for other PR
|
I will re-run the tests now than NM is merged |
This test verifies that when used, newlib-nano is correctly included, both header and also linked. (cherry picked from commit db00922)
cladmi
force-pushed
the
2018.07/pr/make/newlib/add_test_for_newlibnano
branch
from
9121526
to
5661e1b
Compare
|
I re-tested that it works for the given board and that I can make the test fail by commenting the same lines as in the original PR comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #9599
Contribution description
This test verifies that when used, newlib-nano is correctly included, both
header and also linked.
This is a standalone test and is less invasive than doing a global test like what I tried in #9512
I want to use it to debug non handled developers computers.
Testing
I tested the following setups:
Issues/PRs references
#9512
This should not be merged before #9398 as currently llvm is not handled properly but it should not block adding tests in murdock.I now think it should be included before #9398, I thought it would be all fixed faster.
I already have a fix for the llvm/clang issue #9513