This repository has been archived by the owner on Sep 20, 2022. It is now read-only.
LwM2M/SAUL temperature app #66
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wakaama-temp/Makefile.ci
Outdated
| @@ -0,0 +1,60 @@ | |||
| BOARD_BLACKLIST := \ | |||
There was a problem hiding this comment.
After RIOT-OS/RIOT#12872 the blacklist should not be necessary
wakaama-temp/temp_reader.c
Outdated
| _temp_instance = instance; | ||
|
|
||
| _uri.flag = LWM2M_URI_FLAG_OBJECT_ID | LWM2M_URI_FLAG_INSTANCE_ID | | ||
| LWM2M_URI_FLAG_RESOURCE_ID; |
wakaama-temp/temp_reader.c
Outdated
Comment on lines
62
to
68
| DEBUG("temperature: %d.%02d C\n", phy.val[0] / 100, phy.val[0] % 100); | ||
| } | ||
| else { | ||
| DEBUG("Sensor read failure: %d\n", res); | ||
| } | ||
|
|
||
| _temp_instance->sensor_value = (double)phy.val[0] / 100; |
There was a problem hiding this comment.
As SAUL_DRIVER is configurable, maybe use the phy.scale value here to format the temperature?
There was a problem hiding this comment.
Yes, formatting is needed. Thanks for the pointer to this attribute; I was unaware.
kb2ma
commented
Dec 10, 2019
| /* Priority is main-6 because LwM2M is main-1, and network stack is below | ||
| * that. */ | ||
| _pid = thread_create(_msg_stack, sizeof(_msg_stack), | ||
| THREAD_PRIORITY_MAIN - 6, THREAD_CREATE_STACKTEST, |
There was a problem hiding this comment.
@leandrolanzieri, I would appreciate any ideas you have on management of thread priorities. Subtraction by 6 is hacky, and I also had to change the default priority level on native (see Makefile) to accommodate this.
It seems like there should be something like identified min/max priorities for application threads.
|
Comments addressed. |
3 tasks
miri64
previously requested changes
Jan 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This application extends the RIOT LwM2M Wakaama example to periodically sample a SAUL temperature sensor and make the value available as a LwM2M measured temperature (/3303) object. The app also can be run with a "native" board without a SAUL sensor. In this case the temperature value simply increases with each measurement.
This implementation provides partial support for the LwM2M definition for measured temperature, including only the sensor value and units.
The app works fine, but should be considered a WIP for a couple of reasons:
measured_temp.(c|h)module belongs with the Wakaama pkg in RIOT. I plan to create a separate PR to add that. Once that is merged, I can update this PR to reference it instead.Testing procedure
See README.md to set up and run the app.
For temperature readings, I use a Microchip MCP9808 sensor with the RIOT JC42 driver. Adafruit makes it easy for those of us who live in the higher levels of the stack. :-)