Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transform accounts modal to a page #90

Closed
theperu opened this issue May 10, 2023 · 5 comments · Fixed by #118
Closed

Transform accounts modal to a page #90

theperu opened this issue May 10, 2023 · 5 comments · Fixed by #118
Assignees
Labels
enhancement New feature or request frontend This is frontend related

Comments

@theperu
Copy link
Collaborator

theperu commented May 10, 2023

Currently the lower part of every account modal shows some weird things instead of the right transactions. I think we can re-use a lot of the work that as been done for the transaction page by @GBergatto (#84 )
Figma link for reference

EDIT: After discussing this issue on discord we decided to remove the modal and use a page instead

@theperu theperu added enhancement New feature or request frontend This is frontend related labels May 10, 2023
@theperu theperu added this to the 0.1alpha-pre-release milestone May 10, 2023
@GBergatto
Copy link
Contributor

I'm a bit busy in this period but I'll take a look

@GBergatto
Copy link
Contributor

I've quickly tried to copy and paste some code from lib/pages/transactions_page/widgets/list_tab.dart and it works.

@GBergatto
Copy link
Contributor

I've also noticed that we have a few blocks of code that do almost the same thing scattered across the codebase. For example, I've created a widget to display a transaction inside lib/pages/transactions_page/widgets/transaction_list_tile.dart and something very similar has been done inside lib/custom_widgets/transactions_list.dart.

I believe we should define some rules on how to make widgets more reusable to avoid rewriting the same code over and over and to keep some consistency across different pages.

Each page should be wrapped inside its own folder and broken down into multiple widgets. If those widgets are specific to that page they should stay inside a widgets subfolder. If they are shared across different pages (like the one for transactions) they should stay inside a shared folder like lib/custom_widgets

@theperu
Copy link
Collaborator Author

theperu commented May 21, 2023

Yes, I 100% agree with you. Unfortunately sometimes we haven't followed this practice but we will try to focus more on this and also in the near future we will take a look at the code and try to fix this kind of things once and for all.

@GBergatto
Copy link
Contributor

@theperu can you please edit the description of this issue to say that, as discussed on Discord, we will transform this modal into a regular page? I'm starting to work on it now.

@theperu theperu changed the title Fix bottom part of the accounts modal Transform accounts modal to a page Aug 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend This is frontend related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants