-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transform accounts modal to a page #90
Comments
I'm a bit busy in this period but I'll take a look |
I've quickly tried to copy and paste some code from |
I've also noticed that we have a few blocks of code that do almost the same thing scattered across the codebase. For example, I've created a widget to display a transaction inside I believe we should define some rules on how to make widgets more reusable to avoid rewriting the same code over and over and to keep some consistency across different pages. Each page should be wrapped inside its own folder and broken down into multiple widgets. If those widgets are specific to that page they should stay inside a |
Yes, I 100% agree with you. Unfortunately sometimes we haven't followed this practice but we will try to focus more on this and also in the near future we will take a look at the code and try to fix this kind of things once and for all. |
@theperu can you please edit the description of this issue to say that, as discussed on Discord, we will transform this modal into a regular page? I'm starting to work on it now. |
Currently the lower part of every account modal shows some weird things instead of the right transactions. I think we can re-use a lot of the work that as been done for the transaction page by @GBergatto (#84 )
Figma link for reference
EDIT: After discussing this issue on discord we decided to remove the modal and use a page instead
The text was updated successfully, but these errors were encountered: