Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor widgets code #108

Open
mikev-cw opened this issue Jul 4, 2023 · 6 comments
Open

Refactor widgets code #108

mikev-cw opened this issue Jul 4, 2023 · 6 comments
Assignees

Comments

@mikev-cw
Copy link
Collaborator

mikev-cw commented Jul 4, 2023

Some widgets are now builded from scratch every time.
We need to standardize this part of the codebase

@mikev-cw mikev-cw changed the title Refactor widget code Refactor widgets code Jul 4, 2023
@GBergatto
Copy link
Contributor

I'll start doing some work related to this issue while working on the ex Account modal for issue #90

@giuseppe-coco
Copy link

Hi, I am new to the project and would like to contribute.

@mikev-cw , do you mean that in the code there are identical widgets repeated many times that you would like to modularize into a class?

Can you give an example in the code of which widgets you would like to convert into a separate class?

@GBergatto
Copy link
Contributor

Welcome! Yes, there are some widgets that are shared across multiple pages but are created from scratch on each of them. The goal is to define widgets that we can reuse across the page to make the code more organized and avoid having to rewrite the same things over and over. An example, is lib/custom_widgets/transactions_list.dart which I've worked on in my last PR #118.

@giuseppe-coco
Copy link

Hello, sorry for my late response but I'm currently working and haven't had much time to devote to the project.

I noticed some strange things that did not allow me to understand in detail the functions of the app and the related widgets that control them, so I could not make changes.

Specifically , the app cannot find the "Main Account" .

graphs home transactions

@GBergatto
Copy link
Contributor

@giuseppe-coco I think that that happens because you don't have any transactions, yet. Try to go to "Settings" and, in the "dev only" zone, do "clear and fill demo data". This will create a bunch of random transactions in the local database

@giuseppe-coco
Copy link

Yes that was the problem, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants