Improvements to "Transactions" page #84
Conversation
Calculate total for each day Get category and bank account for each transaction
Get categories and transactions from database. Group transactions under their category and calculate total. Calculate percentage for each category.
The error shown on discord is caused by a typing error at line 149 of the file (14, "Leisure", "subscriptions", '', null, '${DateTime.now()}', '${DateTime.now()}');
15, "Salary", "work", '', null, '${DateTime.now()}', '${DateTime.now()}');The semicolon at the end of the line should be a comma. I have fixed this on my local fork but haven't committed the change as I thought it would have been out of scope for this PR. @lucaantonelli said he was fixing a few issues with the database. If you want me to, I can make all comments start with uppercase letters. However, I think it would be a bit overkill, considering that, as far as I know, no convention about comments has been established. (Maybe we should establish one now) |
Agreed. |
I improved the List and Categories tabs. Here are two screenshots of how they look now.
Currently, all transactions are queried from the database regardless of their date. We should query only the ones in the selected time frame. Also, the totals for the day and for each category are calculated in the build method of the widgets, which is not ideal. It might be better to retrieve them directly from the database with a designated query. The same goes for the groupings of transactions in their categories in the "Categories" tab.
The list of expandable categories in the "Categories" tab is wrapped in a
Sizeboxwhose size is calculated every time a category is expanded. While a category gets collapsed, aRenderFlex overflowedis sometimes thrown, because the new size is computed before the end of the animation. After the animation is over, everything is fine.If you can think of a better solution, please tell me.
What's missing