-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix warning messages for Rails 6 and Zeitwerk #54
Conversation
sobrinho
commented
Mar 30, 2023
•
edited
edited
Can we get this merged @pond? |
I'll get to this as soon as I can. Sorry for the delay - I was in the UK for 2 weeks (where my family lives - first trip back there for 5 years!) but thanks to lots of people coughing without masks on both of the long haul flights home, I came down with flu the day after I got back. Illness combined with 11 hours of jet lag (to NZ) hit rather hard and I'm only just starting to catch back up on everything now. |
NB The Rails 7 branch already does this; didn't realise Rails 6 was starting to generate such noise; white space aside (Rails 7 has the code inside to-prepare indented) I see nothing wrong with the solution so should be mergeable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the submission! Request for indication is given in review comment - the idea is to reduce the number of differences between this and the main Rails 7 branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the submission! Request for indication is given in review comment - the idea is to reduce the number of differences between this and the main Rails 7 branch.
Thanks 👍 😄 |
This breaks Ruby 2.7 in CI - I guess I must have something wrong in my GitHub configuration given that this wasn't warned about prior to the PR merge. The issue is that (for some reason on Ruby 2.7 only) an existing application's own (An existing, unmodified application initializer would be run before one wrapped in This puts us in the very awkward position of introducing a breaking change but being unable to update the major version per semver, because V2 is the Rails 7 gem. I'm considering options, but v1.5.3 won't be released for now as a result of the above. |
…r-54 Backwards-compatible modifications to support #54
Very sorry for the passing of so many months. Workload is unrelenting and extraordinary at the moment. #63 finally "officially" resolves the backwards compatibility issues, merges to |