Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backwards-compatible modifications to support #54 #63

Merged
merged 4 commits into from
Sep 16, 2023

Conversation

pond
Copy link
Member

@pond pond commented Sep 16, 2023

Support #54 but with backwards compatibility. Applications that don't use to_prepare will no longer have their configuration updated by Scimitar's defaults via its own to_prepare block.

@pond pond added bug Something isn't working maintenance Dependency updates and general code quality labels Sep 16, 2023
@pond
Copy link
Member Author

pond commented Sep 16, 2023

Self-review of diff provoked a few minor changes; now all looks good; CI green on all phases. Merging; will release this version to RubyGems soon after.

@pond pond merged commit a73a8ea into v1 Sep 16, 2023
4 checks passed
@pond pond deleted the feature/backwards-compatible-pr-54 branch September 16, 2023 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working maintenance Dependency updates and general code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant