Synchronize option, limits and defaults with the API #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and include a new dev script for checking the tools against the OpenAPI endpoint.
|
The other day i tried to use |
Jterbeest
reviewed
Oct 11, 2017
| @@ -50,7 +50,7 @@ def add_arguments(self): | |||
| ) | |||
| specific.add_argument( | |||
| "--port", | |||
| type=ArgumentType.integer_range(minimum=1, maximum=2**16), | |||
| type=ArgumentType.integer_range(minimum=1, maximum=65535), | |||
There was a problem hiding this comment.
Does it make sense to allow HTTP measurements to every possible port?
There was a problem hiding this comment.
I don't know actually, I guess it's okay? But if we restrict it we should do it on the API side first.
Jterbeest
approved these changes
Oct 11, 2017
|
@astrikos you're right, resolve_on_probe was missed by my checker because I was conflating it with use_probe_resolver. I'll add it with this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Synchronize option, limits and defaults with the API where relevant,and include a new dev script for checking the tools against the OpenAPI endpoint.
This means adding a few more options that are supported by the API but not the tools, and aligning the minimums and maximums with current reality. In general the behaviour of the CLI has not changed, except that server-side validation errors are less likely and certain values are now possible.