Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolves #231 (Update IRC Config to contain new field (IRC_CHANNEL_KEY)) #261

Merged
merged 1 commit into from Mar 9, 2020
Merged

Resolves #231 (Update IRC Config to contain new field (IRC_CHANNEL_KEY)) #261

merged 1 commit into from Mar 9, 2020

Conversation

Zedjones
Copy link
Member

@Zedjones Zedjones commented Mar 9, 2020

This commit adds support for joining password-protected IRC channels.

@Zedjones Zedjones added this to In progress in TeleIRC development via automation Mar 9, 2020
@Zedjones Zedjones added this to the v2.0.0 milestone Mar 9, 2020
@Zedjones Zedjones linked an issue Mar 9, 2020 that may be closed by this pull request
Update IRC Config to contain new field (IRC_CHANNEL_KEY) #231
Closed
@Zedjones Zedjones self-assigned this Mar 9, 2020
@jwflory jwflory added improvement Improves on something that already exists IRC Issues relating to the IRC bridge needs review Pending a peer review before merging or closing labels Mar 9, 2020
@jwflory jwflory requested a review from a team March 9, 2020 19:23
jwflory
jwflory approved these changes Mar 9, 2020
View reviewed changes
Copy link
Member

@jwflory jwflory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple enough, I grok this PR. I see IRC_CHANNEL_KEY is already in env.example, so I'm approving and merging. Thanks @Zedjones! 🌊

@jwflory jwflory merged commit 7914f4e into RITlug:go-port Mar 9, 2020
TeleIRC development automation moved this from In progress to Done Mar 9, 2020
@jwflory jwflory removed the needs review Pending a peer review before merging or closing label Mar 9, 2020
@jwflory jwflory self-assigned this Mar 9, 2020
@jwflory jwflory mentioned this pull request Mar 9, 2020
Closed
jwflory pushed a commit that referenced this pull request Mar 27, 2020
@Zedjones @jwflory
Added support for joining IRC channels with passwords (#261)
24d57b4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwflory jwflory jwflory approved these changes

Assignees

@jwflory jwflory

@Zedjones Zedjones

Labels
improvement Improves on something that already exists IRC Issues relating to the IRC bridge
Projects
TeleIRC development
  
Done
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.

Update IRC Config to contain new field (IRC_CHANNEL_KEY)
2 participants
@Zedjones @jwflory