fmt/log.Println like logging, Adding more verbosity #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kennedy
commented
Mar 28, 2020
kennedy
commented
- Increased verbosity:
- Whenever an irc handler triggers
- Whenever an irc event handler has been added. Provides more details into which handlers were added.
- Added log notification when telegram bot has logged in.
Increased verbosity for ircc handler triggers. Logging each event handler as it is added, instead of a general add. Provides more details into which handlers were added. Added log notification when telegram bot has logged inn.
kennedy
commented
Mar 28, 2020
| @@ -14,33 +14,33 @@ var ( | |||
|
|
|||
| // DebugLogger provides an interface to call the logging functions | |||
| type DebugLogger interface { | |||
There was a problem hiding this comment.
Behaves just like fmt.Println() or log.Println()
for example: logger.LogInfo("random pre-fix string", 10) # random pre-fix string 10
kevinassogba
approved these changes
Mar 28, 2020
There was a problem hiding this comment.
The use of interface is definitely a good idea. Overall, I think is it a good PR. Before merging, would you add a space before concatenating string on these lines?
c.logger.LogInfo("Adding IRC event handler:", eventType)
tg.logger.LogInfo("Authorized on account",tg.api.Self.UserName)
@10eMyrT Fortunately a space is automatically joined between the interfaces |
|
mergeeeed |
jwflory
added
improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.