Add steel cement aviation aps steps #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #61 +/- ##
==========================================
- Coverage 16.83% 16.75% -0.09%
==========================================
Files 13 13
Lines 2049 2059 +10
==========================================
Hits 345 345
- Misses 1704 1714 +10 ☔ View full report in Codecov by Sentry. |
|
@Antoine-Lalechere can we have a live discussion about this, ideally with @jacobvjk and @jdhoffa once he's back from vacation? On the surface, this appears to change code that has broad effect on things beyond just the Swiss COP, so I want to make sure we're not causing a detrimental effect elsewhere. |
cjyetman
approved these changes
Jun 28, 2024
jdhoffa
added a commit
to RMI-PACTA/workflow.data.preparation
that referenced
this pull request
Jun 28, 2024
…viation Update `2023Q4` data prep config to pick-up the latest run of scenario preparation, which now includes new scenarios `APS` and `STEPS` for the sectors steel, cement and aviation, for the `WEO2023` scenario. Relates to RMI-PACTA/pacta.scenario.data.preparation#61
jdhoffa
added a commit
to RMI-PACTA/workflow.data.preparation
that referenced
this pull request
Jun 28, 2024
... for steel cement and aviation. Update `2023Q4` data prep config to pick-up the latest run of scenario preparation, which now includes new scenarios `APS` and `STEPS` for the sectors steel, cement and aviation, for the `WEO2023` scenario. Relates to RMI-PACTA/pacta.scenario.data.preparation#61
jdhoffa
added a commit
that referenced
this pull request
Jun 29, 2024
The bug was introduced in #61 Since we never load `dplyr`, namespacing is important. This resulted in the latest build of scenario prep not building `weo_2023`. This slipped through our CI/CD because we currently set it to fail on `WARNING` rather than `NOTE`, and the lack of visible global binding only raises a NOTE. FYI @Antoine-Lalechere @AlexAxthelm @cjyetman
cjyetman
pushed a commit
that referenced
this pull request
Jun 29, 2024
The bug was introduced in #61 Since we never load `dplyr`, namespacing is important. This resulted in the latest build of scenario prep not building `weo_2023`. This slipped through our CI/CD because we currently set it to fail on `WARNING` rather than `NOTE`, and the lack of visible global binding only raises a NOTE. FYI @Antoine-Lalechere @AlexAxthelm @cjyetman
jdhoffa
added a commit
to RMI-PACTA/workflow.data.preparation
that referenced
this pull request
Jul 1, 2024
The initial scenario preparation configuration bump that was committed in #236 and #237 pointed to a scenario preparation output that was missing crucial data. The data was missing due to a bug that was introduced in: RMI-PACTA/pacta.scenario.data.preparation#61 and later solved by: RMI-PACTA/pacta.scenario.data.preparation#63 The new scenario preparation outputs, in the directory: `2023Q4_20240701_T105302Z` which can be found here: https://pactadatadev.file.core.windows.net/workflow-scenario-preparation-outputs/2023Q4_20240701_T105302Z contain all the expected output datasets.
jdhoffa
added a commit
to RMI-PACTA/workflow.data.preparation
that referenced
this pull request
Jul 1, 2024
The initial scenario preparation configuration bump that was committed in #236 and #237 pointed to a scenario preparation output that was missing crucial data. The data was missing due to a bug that was introduced in: RMI-PACTA/pacta.scenario.data.preparation#61 and later solved by: RMI-PACTA/pacta.scenario.data.preparation#63 The new scenario preparation outputs, in the directory: `2023Q4_20240701_T105302Z` which can be found here: https://pactadatadev.file.core.windows.net/workflow-scenario-preparation-outputs/2023Q4_20240701_T105302Z contain all the expected output datasets.
jdhoffa
added a commit
to RMI-PACTA/workflow.transition.monitor
that referenced
this pull request
Jul 1, 2024
The newly created data directory now contains APS and STEPS scenarios for WEO 2023 for the aviation, cement and steel sectors. With these scenarios missing, the executive summary couldn't render correctly. Relates to: RMI-PACTA/workflow.data.preparation/pull/238 RMI-PACTA/workflow.data.preparation/pull/237 RMI-PACTA/workflow.data.preparation/pull/236 RMI-PACTA/pacta.scenario.data.preparation/pull/61 RMI-PACTA/pacta.scenario.data.preparation/pull/63
jdhoffa
added a commit
to RMI-PACTA/workflow.transition.monitor
that referenced
this pull request
Jul 18, 2024
The newly created data directory now contains APS and STEPS scenarios for WEO 2023 for the aviation, cement and steel sectors. Importantly also, we had to update paths to the new (real) `peer` files, as those had to be re-run with those same latest scenarios. With these scenarios missing, the executive summary couldn't render correctly. Relates to: RMI-PACTA/workflow.data.preparation/pull/238 RMI-PACTA/workflow.data.preparation/pull/237 RMI-PACTA/workflow.data.preparation/pull/236 RMI-PACTA/pacta.scenario.data.preparation/pull/61 RMI-PACTA/pacta.scenario.data.preparation/pull/63 --------- Co-authored-by: Alex Axthelm <aaxthelm@rmi.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Switzerland project, we are providing an aggregate score to any investors.
The calculation of this indicator was previously made with GECO, but as we get some concerns with some GECO value in their last release, it will be provided against WEO2023 this year.
To compute this indicator, we need to compute targets against three scenarios as the results we provide will be for example "Between APS and STEPS". We would then need to add Aviation, Steel and Cement targets based on APS and STEPS.