Fixing overlay experiments with instance variables #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ryVariable and ArgumentVariable
updating ASTInterpreter and ASTPostOrderTreeVisitor according to new AST visitor API
…cy to the baseline
removing deprecated spec-debugger dependency + adding espell dependen…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests were red in DebuggableASTInterpreterOverlays because overlays weren't created.
This was because, to register an overlay for a given pc when an instance variable was assigned, the
DASTOverlayInterpreter>>#write:toInstVarNamed:(that overridesDASTContext>>#write:toInstVarNamed:should have been called. However, it wasn't called as it was letting the DASTContext directly write into the instance variable.I fixed it so that the
DASTOverlayInterpreter>>#write:toInstVarNamed:is really called to create the overlays and all tests are green now (except those related to proxies as something is broken with Ghost).It shouldn't have any impact when we use the
DASTIntepreter>>#write:toInstVarNamed:lets the context directly write into the instance variable, just like before.This shouldn't be merged yet because I have to solve some conflicts and we should create a new branch for the overlay experiment, as we said