Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it easier to update Traveler #56

Closed
AntonPetrov opened this issue Sep 29, 2021 · 0 comments · Fixed by #89
Closed

Make it easier to update Traveler #56

AntonPetrov opened this issue Sep 29, 2021 · 0 comments · Fixed by #89
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@AntonPetrov
Copy link
Member

We need to develop an easier way to update Traveler in R2DT. Currently there is a set of test sequences and their corresponding diagrams. The tests only pass if all newly generated diagrams are identical to the examples, which gives confidence that no accidental changes affecting the layouts were introduced. However, any upstream changes in Traveler require updating all or most example diagrams which is a manual process.

I suggest to implement:

  • a new r2dt.py command to compute new diagrams for the example sequences
  • organise the new and old diagrams in a way that makes it easy to compare them visually (in a folder with consistent names or as an HTML report)
  • once the layouts are verified, another new command should replace the example diagrams the new ones.
@AntonPetrov AntonPetrov added enhancement New feature or request good first issue Good for newcomers labels Sep 29, 2021
AntonPetrov added a commit that referenced this issue Sep 18, 2023
Use image comparison instead of file comparison

Fixes #56
@AntonPetrov AntonPetrov mentioned this issue Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant