Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate image build for base image #104

Closed
wants to merge 6 commits into from
Closed

Separate image build for base image #104

wants to merge 6 commits into from

Conversation

anayden
Copy link
Collaborator

@anayden anayden commented Aug 29, 2023

No description provided.

@AntonPetrov AntonPetrov self-assigned this Aug 29, 2023
@AntonPetrov
Copy link
Member

@anayden This is awesome, thank you! Splitting up the image into 2 would really help iterate faster and I like how you moved software versions into variables 👏👏👏

Just wondering if there could be a race situation 🚗🏎️ when a commit changes both the base Dockerfile and the python Dockerfile. Then there would be 2 concurrent GitHub workflows building 2 images, and the main workflow could theoretically pull an old base Docker image because the new one would not be ready yet. That could lead to some tricky bugs! 🤔

Is this a problem or am I missing something? It looks like it is possible to connect workflows but I have not used this before.

Also the automatic checks were not successful because of some Slack secrets. Do you know how to fix it or I am happy to investigate myself?

Thanks again! You identified a major pain point and proposed a nice fix, so great stuff! 😎🚀

@anayden anayden closed this by deleting the head repository Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants