Allow full local build for arbitrary platforms #119
Conversation
|
Docker image tag(s) pushed: Labels added to images: |
justfile
Outdated
| base_image := "rnacentral/r2dt-base" | ||
| image := "rnacentral/r2dt" | ||
| tag := "latest" |
There was a problem hiding this comment.
@anayden The tag variable does not seem to be used in the script, so it should be either removed (👎) or used in combination with BASE_IMAGE_VERSION argument (👍).
There was a problem hiding this comment.
It's unused indeed, and I don't think it's needed in combination with BASE_IMAGE_VERSION: when just full-build is executed we specifically want latest to be hardcoded as the value for BASE_IMAGE_VERSION because that's the tag base image will be locally built with. Any changes to this value will actually break full-build.
So, I'm sorry but tag has to go :(
justfile
Outdated
|
|
||
| # Build R2DT Docker image | ||
| build: | ||
| docker buildx build {{platform}} -t {{image}} . | ||
| build *BUILD_ARGS: |
There was a problem hiding this comment.
It is not immediately clear how to use this to build using a certain base image tag (pr-120 for example). Would it be possible to document how to use this in docker.md?
There was a problem hiding this comment.
Good idea. Added a new command and documented it
There was a problem hiding this comment.
The new tag-build is awesome, thank you! Could it apply the same tag to the resulting R2DT image (currently it becomes latest which might be a bit dangerous)?
There was a problem hiding this comment.
Could it apply the same tag to the resulting R2DT image (currently it becomes latest which might be a bit dangerous)?
I have two questions here:
- What do you mean by applying the same tag to the resulting image?
tag-buildalready builds the resulting R2DT image… - What's dangerous in having the
latesttag locally by default? Isn't it what every default docker build does? I understand dangers of pushinglatestto DockerHub, but pushing is done via GH Actions and they don't pushlatestanyway.
I'm a bit confused, as you might notice :)
There was a problem hiding this comment.
Sure, let me clarify:
What do you mean by applying the same tag to the resulting image?
If I do just tag-build pr-xxx I would like to get rnacentral/r2dt:pr-xxx as a result. Why? Read on!
What's dangerous in having the latest tag locally by default?
Imagine a situation when you review pr-xxx, find a bug 😱, report it on GH, and switch to something else. Later on you do just run, but because tag-build created an image tagged with latest, now you are running not a bug-free latest image, but an image based on the pr-xxx branch. This could create some nasty and hard to find bugs 🐛
Feel free to push back if I am overthinking it 🤔
There was a problem hiding this comment.
Ok, I see what you mean now. I've pushed the change: now just tag-build TAG builds both base and main images with this tag. But now you have to remember just run and just test work with the latest image, not with your custom one :)
justfile
Outdated
| docker buildx build {{ platform_arg }} -t {{ base_image }} base_image | ||
|
|
||
| # Build base and then the r2dt images locally | ||
| full-build: bbuild (build "--build-arg BASE_IMAGE_VERSION=latest") |
There was a problem hiding this comment.
Is this a good place to use the tag variable?
There was a problem hiding this comment.
Not really, as explained above
|
Thank you for the PR! I was looking at it in conjunction with #120 and wanted to build a local R2DT image using the new base image created by GH Actions to run tests and confirm that the final image is functional before merging (or is the idea to couple building both images so that it's all done in the cloud)? Ideally I'd want to do something like Could you please explain (here or in |
No description provided.