Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Begin work on differentiating URS pages from URS_taxid pages #450

Closed
wants to merge 3 commits into from

Conversation

AntonPetrov
Copy link
Member

@AntonPetrov AntonPetrov commented Feb 15, 2019

The idea is to clearly differentiate between URS and URS_taxid pages.

Examples

⚙️🛠 Not ready for merging - I would like to clean up the sequence.html template.

Fixes #357

@AntonPetrov AntonPetrov added the SAB Suggestion from our SAB label Feb 15, 2019
@AntonPetrov AntonPetrov self-assigned this Feb 15, 2019
@AntonPetrov
Copy link
Member Author

@blakesweeney @BurkovBA Please have a look at the new non-species-specific pages in this branch and let me know if you have any feedback. Thank you!

@BurkovBA
Copy link
Contributor

BurkovBA commented Feb 15, 2019

I don't mean to be critical, but may I express some suggestions?

First, I'd expect more consistency in the common part of species-specific and non-species-specific pages, in the location of "87 nucleotides" signature etc.

Second, I think the non-species specific page is very patchy. The fonts with links to species-specific pages are too big in my opinion and inconsistent with the rest of the website. Maybe the green well with "URS00001DA281 is a tRNA found in 38 species" is unnecessary - again, it makes the page too unstructured. There's too much diversity in fonts and colors.

@blakesweeney
Copy link
Member

I agree with boris about the font size and green well. I'd shrink the font to the standard size we use and replace the green well with something more similar to the standard section we use. Also, are the organism names in the list not part of the link to species specific pages?

@AntonPetrov
Copy link
Member Author

Thanks folks! Will see what I can do.

My main concern is that Google keeps a bunch of URS (no taxid) pages in the index, so it should be clear what to do next for people who navigate there from Google. That's what I tried to do with the green banner and the large font for the URS-specific links.

@AntonPetrov
Copy link
Member Author

Closed in favour of #493

@AntonPetrov AntonPetrov deleted the update-non-species-specific-pages branch February 25, 2020 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SAB Suggestion from our SAB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the difference between a generic page and a species specific page clear
3 participants