Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python to dynamixel_sdk ROS package #187

Closed
roncapat opened this issue May 15, 2018 · 4 comments
Closed

Add python to dynamixel_sdk ROS package #187

roncapat opened this issue May 15, 2018 · 4 comments
Assignees

Comments

@roncapat
Copy link
Contributor

Hi @ROBOTIS-Leon, I recently started to learn and work a bit more with ROS and its package system. Now that a Python port of the SDK is starting to take a good shape, I suggest to think about how to make it available as ROS package.

Currently, only the /c++ subfolder in this repo has a CMakeLists.txt and a package.xml, with ROS package name dynamixel_sdk.

Few requirements IMHO:

  • the actual package name should not be changed
  • the python version should not be distributed as another package with alternate name

Any thoughts? The simple solution would be moving the python folder in the existing package, but this would violate the separation of languages between folders in this repo...

@LeonJung
Copy link
Contributor

@roncapat

This is not perfectly decided thing, but perhaps the folder (the repository) will be divided into the non-ROS and for-ROS.

in non-ROS, the python package will be as it is, and aims to pypi release.
in for-ROS, the python package will get into src folder, so that the folder structure can be really for-ROS.
of course, setup.py will be modified to ROS setup.py

@robotpilot
Copy link
Member

I am thinking of providing a separate ROS package for Python.

@robotpilot
Copy link
Member

I created a new folder called ros for both the C ++ and Python versions of the ROS package and put both languages here (v3.6.2). #211

ROS users can now use both the C ++ version of the library and the Python version of the module. Our team will make use of it as an example in dynamixel_workbench.

The new version of dynamixel_sdk's ROS package is currently awaiting registration.
ROS Indigo: ros/rosdistro#18514
ROS Kinetic: ros/rosdistro#18515
ROS Melodic: ros/rosdistro#18516

@robotpilot
Copy link
Member

I'm going to close this until you update the issue with more information. If you do so I'll reopen the issue.
Thank you for your consideration and supports. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants