Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the tf tree according to the one of realsense camera #82

Conversation

robograffitti
Copy link
Contributor

To resolve #81 , fixed the tf tree according to the one of realsense camera and out deprecated parameters.

@routiful
Copy link

Hi :) @yoshimalucky

Our tf tree of Realsense is based on turtlebot example
But this tf tree is different from realsense nodelet tree (You pointed out it issue #81)

Thank you for your contribution. We are welcome to any comment.
But, in our rule, we only permit to merge commit into develop branch.
If you request again into develop branch, we merge your commit.

Thanks
Darby

@robograffitti
Copy link
Contributor Author

@routiful Thanks for your comment. I'm closing this PR. And, fist I discuss this topic in the turtlebot repository.

@routiful
Copy link

I will merge your contribution into turtlebot3 develop branch myself.

Thanks
Darby

@robograffitti
Copy link
Contributor Author

Thanks.

I could not understand your meaning at first, but I finally found it here:
e153011

This type of copy and paste is not a good behavior in our OSS comunity because this is my contribution.

In this case, you should tell me to close this PR and recreate another PR from my branch to the develop branch.

@routiful
Copy link

routiful commented Jan 9, 2018

Oh, my mistake. I'm truly sorry for you.
I'm going to do as you point out to me.

Sincerely
Darby.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

R200 TF tree is incorrect.
2 participants