[HIPIFY][doc] Added -DLLVM_INCLUDE_TESTS=OFF to LLVM build command lines
#1024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lines [Reasons] + No need for any LLVM tests for hipify-clang building or testing + Reduce build time and avoid possible issues with tests
emankov
added
documentation
emankov
added a commit
to emankov/HIPIFY
that referenced
this pull request
Sep 19, 2023
…VM >= 10.0.0 anymore [Reason] + With excluding tests from LLVM building (ROCm#1024), it turned out that building of any of the LLVM targets (`X86` or `NVPTX`) are not needed for hipify-clang as well: - Actually, there were some minor dependencies (probably erroneous) between some tests and targets in some LLVM versions, which were entirely gone with tests' exclusion + It was needed to check `-DLLVM_TARGETS_TO_BUILD=""`, because hipify-clang is also can be built under `HIPIFY_INCLUDE_IN_HIP_SDK` against ROCm's LLVM, which build is not targeting `NVPTX` + Reduction of LLVM compilation time up to two times + Building and testing of hipify-clang were checked against all LLVM versions >= 10.0.0 built with `-DLLVM_TARGETS_TO_BUILD=""` [ToDo] + [Not IMP] Check `-DLLVM_TARGETS_TO_BUILD=""` for LLVM < 10.0.0
emankov
added a commit
that referenced
this pull request
Sep 20, 2023
[HIPIFY][#1024][doc] Do not need to build any LLVM targets for LLVM >= 10.0.0 anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Reasons]