Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set default workspaceIndexMode to image index for 3D pooling #366

Merged
merged 1 commit into from
Aug 6, 2020

Conversation

ce1adon
Copy link
Contributor

@ce1adon ce1adon commented Jul 30, 2020

Fix for issue #365

@daniellowell
Copy link
Contributor

@ce1adon This is straight forward. Questions: Is this a breaking change for MIOpen? What was the previous behavior and what is the impact to PyTorch and Caffe2?

@ce1adon
Copy link
Contributor Author

ce1adon commented Aug 4, 2020

@daniellowell
When we added 3D pooling, we didn't have this feature workspaceIndexMode. At that time, 2D pooling adopted mask mode while 3D pooling adopted image mode. Later framework team required us to change 2D pooling to image mode for their unit tests, so we added workspaceIndexMode for user to select index mode and we set the default mode as mask mode for all. However, 3D pooling does not use mask mode. User need to use the new API miopenSetPoolingWorkSpaceIndexMode() to set the workspaceIndexMode to miopenPoolingWorkspaceIndexImage. If not, it will trigger the issue reported. For convenience, the PR set default workspaceIndexMode to image mode for 3D pooling. User can still use miopenSetPoolingWorkSpaceIndexMode() to change the index mode for both 2D and 3D pooling.

@ce1adon ce1adon requested a review from sunway513 August 4, 2020 22:42
@daniellowell daniellowell merged commit fe1b92f into develop Aug 6, 2020
@daniellowell daniellowell deleted the pool3d_check branch November 16, 2020 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants