Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dual mac instruction for gfx11. #1625

Merged
merged 5 commits into from
Dec 6, 2022
Merged

Add dual mac instruction for gfx11. #1625

merged 5 commits into from
Dec 6, 2022

Conversation

hcman2
Copy link
Contributor

@hcman2 hcman2 commented Nov 22, 2022

This is new instructions to boost mac operations in gfx11 platform.

@hcman2 hcman2 changed the title Add dual mac insttruction for gfx11. Add dual mac instruction for gfx11. Nov 22, 2022
Tensile/Components/MAC_F32.py Outdated Show resolved Hide resolved
Tensile/Components/MAC_F32.py Outdated Show resolved Hide resolved
Tensile/Components/MAC_F32.py Outdated Show resolved Hide resolved
Tensile/Components/MAC_F32.py Show resolved Hide resolved
Tensile/Components/MAC_F32.py Show resolved Hide resolved
Tensile/Components/MAC_F32.py Outdated Show resolved Hide resolved
Tensile/Components/MAC_F32.py Outdated Show resolved Hide resolved
Tensile/Components/MAC_F32.py Show resolved Hide resolved
@nakajee
Copy link
Contributor

nakajee commented Nov 25, 2022

Thanks for your update.
I do not have any further comments on the code change.

Do we have some test cases in pre_checkin or extended to verify this feature?

@hcman2 hcman2 closed this Nov 25, 2022
@hcman2 hcman2 reopened this Nov 25, 2022
@hcman2
Copy link
Contributor Author

hcman2 commented Nov 28, 2022

Test cases added in pre_checkin/wave32.

@nakajee
Copy link
Contributor

nakajee commented Nov 28, 2022

Thanks for adding the test cases.
It looks like we need to add the new folder name in pytest.ini to avoid the following warning message.

===
/var/jenkins_home/workspace/clang_precheckin_Tensile_PR-1625/4dRKDTY1u/tensile/Tensile/Tests/yaml_only/test_config.py:76: PytestUnknownMarkWarning: Unknown pytest.mark.wave32 - is this a typo? You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/stable/how-to/mark.html
return getattr(pytest.mark, name)

@hcman2 hcman2 merged commit e98916f into ROCm:develop Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants