Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Use fallback libraries for archs without optimized logic (#1862)" #1879

Merged
merged 2 commits into from
Feb 5, 2024

Conversation

nakajee
Copy link
Contributor

@nakajee nakajee commented Feb 2, 2024

This reverts commit efbe0c0.

@cgmb
Copy link
Contributor

cgmb commented Feb 2, 2024

Why? Was there some sort of error discovered in testing?

@nakajee
Copy link
Contributor Author

nakajee commented Feb 2, 2024

Why? Was there some sort of error discovered in testing?

We are currently encountering test fail on rocblas-internal precheckin test after I updated tensile_tag (including this change (+ some more).
We have not found the cause yet, but this is the only commit which might make difference.
I launched a trial rocblas-internal PR to see if reverting this makes difference or not.
The trial is still on going.

@GZGavinZhao
Copy link
Contributor

#1862 is indeed the PR causing the failure. The failures only happen when the fallback library is built, so AMDGPU_TARGETS=gfx1030;gfx1101 would be fine, but once gfx1010 is added so it becomes AMDGPU_TARGETS=gfx1030;gfx1101;gfx1010 is when rocBLAS suddenly finds itself running incompatible solutions to solve a problem.

@nakajee
Copy link
Contributor Author

nakajee commented Feb 5, 2024

#1862 is indeed the PR causing the failure. The failures only happen when the fallback library is built, so AMDGPU_TARGETS=gfx1030;gfx1101 would be fine, but once gfx1010 is added so it becomes AMDGPU_TARGETS=gfx1030;gfx1101;gfx1010 is when rocBLAS suddenly finds itself running incompatible solutions to solve a problem.

Thanks for your update.
I will revert this change for now.
We will be able to merge it again once we fix the fail.

@nakajee nakajee merged commit 6cc51b4 into ROCm:develop Feb 5, 2024
13 of 15 checks passed
@nakajee nakajee deleted the revert_fallback branch February 5, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants