Refactor f8_t and bf8_t as custom types, enable use of custom types #1167
+1,674
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zjing14
reviewed
Feb 14, 2024
| int static err = 0; | ||
|
|
||
| template <> | ||
| struct vector_type<f8_t, 1> |
There was a problem hiding this comment.
Could we template the vector_type instead of reimplementing it for each new data type?
|
Could you do a performance check to make sure the new custom data type has no impact on the performance of fp8_gemm? |
|
@zjing14 There is no perf drop on example_gemm_xdl_fp8, nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now custom types are supported as source types, their support as destination types is coming soon...