[Debug] Add bf16 as a custom data type #1128
Conversation
| __host__ __device__ bhalf_t() = default; | ||
|
|
||
| __host__ __device__ constexpr bhalf_t(ushort init) : data(init) {} | ||
| }; |
There was a problem hiding this comment.
there will be a discrepancy on data type convert. In old ck we have everything inside ck::type_convert(). But if we use custom struct as data type it's better we take care of all the conversion inside this struct, or we may have change multiple places due to a single data type.
Also the same for INF/NAN/MIN/MAX definition in ck::NumericLimits
This could be our next refactor point for ck tile. cc @zjing14
There was a problem hiding this comment.
Hi @carlushuang, you are totally right that custom types conversion is tricky. In #1167 we refactor f8_t and bf8_t as custom types and refactor components to enable their support including conversion.
|
We don't need to refactor bf16 as a custom type, so this PR is irrelevant. The custom type enablement will be covered in #1167. Closing this PR. |
Use bf16 as a struct containing ushort type of data instead of ushort type directly. Update all the build issues for compatibility. Investigate the compiler crash cause.