Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi-normalization not working for MFMA Arithmetic Instr Mix #68

Closed
coleramos425 opened this issue Jan 17, 2023 · 1 comment
Closed

Multi-normalization not working for MFMA Arithmetic Instr Mix #68

coleramos425 opened this issue Jan 17, 2023 · 1 comment
Assignees
@coleramos425
Labels
bug Something isn't working metric definition Related to the definition of a metric in Omniperf
Milestone
v.1.0.7

Comments

@coleramos425
Copy link
Collaborator

As pointed out by @arghdos in #66,

The values in the MFMA Arithmetic Instr Mix section can only be normalized by # of waves. i.e.

https://github.com/AMDResearch/omniperf/blob/9bc41f3a85b4bea7fa7febdec104983da41b9e51/src/omniperf_analyze/configs/gfx90a/1000_compute-unit-instruction-mix.yaml#L157-L179

SQ_WAVES should be changed to $denom to enable multi-normalization
@coleramos425 coleramos425 added the bug Something isn't working label Jan 17, 2023
@coleramos425 coleramos425 added this to the v.1.0.7 milestone Jan 17, 2023
@coleramos425 coleramos425 self-assigned this Jan 17, 2023
@coleramos425 coleramos425 added the metric definition Related to the definition of a metric in Omniperf label Jan 17, 2023
coleramos425 added a commit that referenced this issue Jan 17, 2023
@coleramos425
Add mult-normalization to MFMA Arithmetic Instr Mix #68
32444e4 
Signed-off-by: colramos425 <colramos@amd.com>
@coleramos425
Copy link
Collaborator Author

The issue has been patched.

Closed
@coleramos425 coleramos425 mentioned this issue Feb 21, 2023
Merged
feizheng10 pushed a commit to feizheng10/omniperf that referenced this issue Dec 6, 2023
@coleramos425
Add mult-normalization to MFMA Arithmetic Instr Mix ROCm#68
d13ef2f 
Signed-off-by: colramos425 <colramos@amd.com>
Signed-off-by: fei.zheng <fei.zheng@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@coleramos425 coleramos425

Labels
bug Something isn't working metric definition Related to the definition of a metric in Omniperf
Projects
None yet
Milestone
v.1.0.7
Development

No branches or pull requests
1 participant
@coleramos425