Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wavefront launch stats also only normalized by waves #81

Closed
skyreflectedinmirrors opened this issue Jan 31, 2023 · 1 comment
Closed

Wavefront launch stats also only normalized by waves #81

skyreflectedinmirrors opened this issue Jan 31, 2023 · 1 comment
Assignees
@coleramos425
Milestone
v.1.0.7

Comments

@skyreflectedinmirrors
Copy link
Contributor

skyreflectedinmirrors commented Jan 31, 2023 •
edited

Similar to #68, these values are only normalizable by waves:

https://github.com/AMDResearch/omniperf/blob/main/src/omniperf_analyze/configs/gfx90a/0700_wavefront-launch.yaml#L101

It would be a good idea to check all the YAML files to get this once and for all
@coleramos425 coleramos425 added this to the v.1.0.7 milestone Jan 31, 2023
@coleramos425 coleramos425 self-assigned this Jan 31, 2023
coleramos425 added a commit that referenced this issue Feb 2, 2023
@coleramos425
Add multi-normalization to wavefront launch #81
57a289a 
Signed-off-by: coleramos425 <colramos@amd.com>
@coleramos425
Copy link
Collaborator

Enabled multi-normalization for

  • Wave Cycles
  • Dependency Wait Cycles
  • Issue Wait Cycles
  • Active Cycles

Others like "Kernel Time (Nanosec)", "Kernel Time (Cycles)", "Instr/wavefront" did not change because their name explicitly defines a static normalization.

coleramos425 added a commit that referenced this issue Feb 13, 2023
@coleramos425
Fix units in wavefront table #81
273c1aa 
Signed-off-by: coleramos425 <colramos@amd.com>
@coleramos425 coleramos425 mentioned this issue Feb 21, 2023
Merged
feizheng10 pushed a commit to feizheng10/omniperf that referenced this issue Dec 6, 2023
@coleramos425
Add multi-normalization to wavefront launch ROCm#81
d0dd11c 
Signed-off-by: coleramos425 <colramos@amd.com>
Signed-off-by: fei.zheng <fei.zheng@amd.com>
feizheng10 pushed a commit to feizheng10/omniperf that referenced this issue Dec 6, 2023
@coleramos425
Fix units in wavefront table ROCm#81
54b3444 
Signed-off-by: coleramos425 <colramos@amd.com>
Signed-off-by: fei.zheng <fei.zheng@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@coleramos425 coleramos425

Labels
None yet
Projects
None yet
Milestone
v.1.0.7
Development

No branches or pull requests
2 participants
@skyreflectedinmirrors @coleramos425