Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added additional arguments for application prof #166

Closed
wants to merge 1 commit into from

Conversation

WillTrojak
Copy link

Added the feature to profile, that additional arguments can be given that are passed to rocprof. This is mainly in response to #164 and to allow trace start to be set, but it seemed that other options may be useful and this was the best solution.

Fixed missing pargs

Split args for pass

Flatten split

Handle case of no arguments

Fixed split
@WillTrojak WillTrojak changed the title Added addiitonal arguments for application prof Added additional arguments for application prof Aug 22, 2023
@coleramos425
Copy link
Collaborator

Thanks for your contribution @WillTrojak. As stated in our CONTRRIBUTING.md guide, we require users sign-off on commits

Omniperf requires new commits to include a "Signed-off-by" token in the commit message (typically enabled via the git commit -s option), indicating your agreement to the projects's Developer's Certificate of Origin and compatability with the project LICENSE:

Before we can accept, please follow instructions here:
image

@coleramos425 coleramos425 deleted the branch ROCm:main-1.x August 2, 2024 16:47
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants