Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Mi300 to 2.x #231

Merged
merged 31 commits into from
Jan 24, 2024
Merged

Adding Mi300 to 2.x #231

merged 31 commits into from
Jan 24, 2024

Conversation

coleramos425
Copy link
Collaborator

@coleramos425 coleramos425 commented Jan 22, 2024

Overview

This pull request adds Mi300 support from our mi300 branch into the 2.x redesign. I've tested these changes on all of the Mi300 varients that we'll be supporting.

From now on, our "source of truth" for supported SoC's is the __supported_archs property of the main Omniperf() class. This value is passed to all sub-classes that need this arch -> GPU name mapping.
https://github.com/AMDResearch/omniperf/blob/131429087b1fe7ec6997c554c7e2f9069d8a057b/src/omniperf_base.py#L50-L57

Major Changes

Notes

  • You'll see we withheld the plotext submodule implemented in the mi300 branch. This will not be merged upstream until the PyPi module is updated. Current ETA is ~ March
    AttributeError: module 'plotext' has no attribute 'box' piccolomo/plotext#196 (comment)
  • Since we're withholding plotext module, some CLI elements are stuck in table view (i.e. l2 cache per channel, mem chart, etc.). Pending the availability of the updated module, we may pivot to other existing Python utilities.
  • Roofline analysis in Mi300 has been temporarily disabled. We still need to verify this feature via independent tests.

Special thanks to @feizheng10 for his contributions in this PR.

src/omniperf_base.py Outdated Show resolved Hide resolved
src/omniperf_base.py Outdated Show resolved Hide resolved
src/utils/specs.py Outdated Show resolved Hide resolved
src/utils/specs.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@koomie koomie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a few minor comments for consideration.

@coleramos425 coleramos425 added this to the v2.0.0 milestone Jan 24, 2024
coleramos425 and others added 20 commits January 24, 2024 16:06
…g fields.

Co-authored-by: fei.zheng <fei.zheng@amd.com>
Signed-off-by: colramos-amd <colramos@amd.com>
… specific to rocprof ver

Signed-off-by: colramos-amd <colramos@amd.com>
Signed-off-by: colramos-amd <colramos@amd.com>
Co-authored-by: fei.zheng <fei.zheng@amd.com>
Signed-off-by: colramos-amd <colramos@amd.com>
Signed-off-by: colramos-amd <colramos@amd.com>
Co-authored-by: fei.zheng <fei.zheng@amd.com>
Signed-off-by: coleramos425 <colramos@amd.com>
Co-authored-by: fei.zheng <fei.zheng@amd.com>
Signed-off-by: coleramos425 <colramos@amd.com>
Signed-off-by: coleramos425 <colramos@amd.com>
Co-authored-by: fei.zheng <fei.zheng@amd.com>
Signed-off-by: coleramos425 <colramos@amd.com>
…l counter updates

Co-authored-by: fei.zheng <fei.zheng@amd.com>
Signed-off-by: coleramos425 <colramos@amd.com>
Co-authored-by: fei.zheng <fei.zheng@amd.com>
Signed-off-by: coleramos425 <colramos@amd.com>
Co-authored-by: fei.zheng <fei.zheng@amd.com>
Signed-off-by: coleramos425 <colramos@amd.com>
Co-authored-by: fei.zheng <fei.zheng@amd.com>
Signed-off-by: coleramos425 <colramos@amd.com>
…ck num

Co-authored-by: fei.zheng <fei.zheng@amd.com>
Signed-off-by: coleramos425 <colramos@amd.com>
…ed to new format

Signed-off-by: coleramos425 <colramos@amd.com>
Signed-off-by: coleramos425 <colramos@amd.com>
Signed-off-by: coleramos425 <colramos@amd.com>
Signed-off-by: coleramos425 <colramos@amd.com>
…modes

Co-authored-by: fei.zheng <fei.zheng@amd.com>
Signed-off-by: coleramos425 <colramos@amd.com>
Signed-off-by: coleramos425 <colramos@amd.com>
Signed-off-by: colramos-amd <colramos@amd.com>
Signed-off-by: colramos-amd <colramos@amd.com>
Signed-off-by: colramos-amd <colramos@amd.com>
Signed-off-by: colramos-amd <colramos@amd.com>
Signed-off-by: colramos-amd <colramos@amd.com>
Signed-off-by: colramos-amd <colramos@amd.com>
Signed-off-by: colramos-amd <colramos@amd.com>
Signed-off-by: colramos-amd <colramos@amd.com>
Signed-off-by: colramos-amd <colramos@amd.com>
Signed-off-by: colramos-amd <colramos@amd.com>
Signed-off-by: colramos-amd <colramos@amd.com>
@coleramos425 coleramos425 merged commit f49d7f7 into 2.x Jan 24, 2024
3 checks passed
@coleramos425 coleramos425 deleted the 2.x-mi300 branch January 31, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants