Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packaging updates #348

Merged
merged 22 commits into from
Apr 21, 2024
Merged

packaging updates #348

merged 22 commits into from
Apr 21, 2024

Conversation

koomie
Copy link
Collaborator

@koomie koomie commented Apr 18, 2024

This PR enables use of cpack to accommodate building of RPM and DEB packages. Install paths have also been updated to reflect ROCm conventions. e.g.

bin/  libexec/  share/

The primary omniperf utility is intended to be accessed from bin/omniperf which is a soft link to the full python install in libexec, e.g.

$ ls -l /tmp/omniperf/bin/omniperf 
lrwxrwxrwx 1 user group 28 Apr 18 10:35 /tmp/omniperf/bin/omniperf -> ../libexec/omniperf/omniperf*

Some new cmake vars introduced:

  • PACKAGE_REQUIRES: external package dependencies (defaults to roc profiler)
  • INSTALL_TESTS: controls whether test collateral is installed (defaults to NO)
  • CHECK_PYTHON_DEPS: whether to check for python and associated runtime dependencies (defaults to YES)

Note that if INSTALL_TESTS=ON, a separate omniperf-tests package will be generated containing testing collateral.

@koomie koomie added this to the v2.0.0 milestone Apr 18, 2024
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
check two locations to cover case where user is running within local
git clone directly or alternatively, from package install.

Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
depending on whether user is running within local clone or from form
install.

Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
to be housed in a separate package

Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
packaging updates

Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
@koomie koomie marked this pull request as ready for review April 21, 2024 19:38
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
@koomie koomie merged commit 144843f into main Apr 21, 2024
9 checks passed
@coleramos425 coleramos425 deleted the package branch August 1, 2024 20:47
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant