Roctracer flush activity fix + perfetto.cfg #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- invoke roctracer_flush_activity() before disabling domains
- real issue was the global state when roctracer_flush_activity() was called
- provide definition of comp::roctracer::flush when OMNITRACE_USE_ROCTRACER is not defined
jrmadsen
force-pushed
the
roctracer-flush-activity-fix
branch
from
85d480c
to
25274f7
Compare
- rename provided perfetto config file (omnitrace.cfg) to perfetto.cfg to avoid confusion
- gpu.hpp: defines for OMNITRACE_USE_{HIP,ROCTRACER,ROCPROFILER,ROCM_SMI}
- gpu.cpp
- include core/hip_runtime.hpp
- fix serialization of hipDeviceProp_t
- add hip_runtime.hpp
- ensure proper inclusion of hip_runtime.h
- add rccl.hpp
- ensure proper inclusion of rccl.h
- rcclp.cpp - update includes for rccl - roctracer.hpp - update includes for hip_runtime - components/comm_data.hpp - update includes for rccl - components/rcclp.hpp - update includes for rccl
- update includes for hip_runtime
- fix find_package for rccl when CI enabled
- set cmake policy CMP0135 to NEW for cmake >= 3.24 - Enable DOWNLOAD_EXTRACT_TIMESTAMP with ExternalProject_Add + URL download method
- include rccl.h only if OMNITRACE_USE_RCCL > 0
- reintroduce some ppdefs
jrmadsen
added
timemory
jrmadsen
changed the title
- fix ifdef on OMNITRACE_HIP_VERSION
- fix static assert for OMNITRACE_HIP_VERSION_MINOR when HIP version 4.x or older (unreliable minor versions)
- fix ifdef on OMNITRACE_HIP_VERSION
- disable OMNITRACE_PERFETTO_COMBINE_TRACES by default
- if unable to open perfetto temp file, return the ReadTraceBlocking()
- flush tmpfile before closing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
roctracer_flush_activity()being invoked inomnitrace_finalizeafter omnitrace set the state toState::Finalizedand the activity callbacks immediately returned becauseget_state() != State::Activeroctracer_flush_activity()is required to ensure that any async activity in roctracer in a partially filled buffer is delivered to omnitrace