Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roctracer flush activity fix + perfetto.cfg #317

Merged
merged 22 commits into from
Jan 10, 2024

Commits on Jan 9, 2024

  1. Fix roctracer_flush_activity

    - invoke roctracer_flush_activity() before disabling domains
    jrmadsen committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    27c52e6 View commit details
    Browse the repository at this point in the history
  2. create comp::roctracer::flush()

    - real issue was the global state when roctracer_flush_activity() was called
    jrmadsen committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    f67ac88 View commit details
    Browse the repository at this point in the history
  3. formatting

    jrmadsen committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    5fa1a20 View commit details
    Browse the repository at this point in the history
  4. Update lib/omnitrace/library/components/roctracer.hpp

    - provide definition of comp::roctracer::flush when OMNITRACE_USE_ROCTRACER is not defined
    jrmadsen committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    25274f7 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2024

  1. omnitrace.cfg -> perfetto.cfg

    - rename provided perfetto config file (omnitrace.cfg) to perfetto.cfg to avoid confusion
    jrmadsen committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    899b484 View commit details
    Browse the repository at this point in the history
  2. Update lib/core

    - gpu.hpp: defines for OMNITRACE_USE_{HIP,ROCTRACER,ROCPROFILER,ROCM_SMI}
    - gpu.cpp
      - include core/hip_runtime.hpp
      - fix serialization of hipDeviceProp_t
    - add hip_runtime.hpp
      -  ensure proper inclusion of hip_runtime.h
    - add rccl.hpp
      - ensure proper inclusion of rccl.h
    jrmadsen committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    9f4b62c View commit details
    Browse the repository at this point in the history
  3. Update lib/omnitrace/library

    - rcclp.cpp
      - update includes for rccl
    - roctracer.hpp
      - update includes for hip_runtime
    - components/comm_data.hpp
      - update includes for rccl
    - components/rcclp.hpp
      - update includes for rccl
    jrmadsen committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    48a2256 View commit details
    Browse the repository at this point in the history
  4. Update bin/omnitrace-avail/avail.cpp

    - update includes for hip_runtime
    jrmadsen committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    95e21aa View commit details
    Browse the repository at this point in the history
  5. Update examples/rccl/CMakeLists.txt

    - fix find_package for rccl when CI enabled
    jrmadsen committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    6776254 View commit details
    Browse the repository at this point in the history
  6. Update CMakeLists.txt

    - set cmake policy CMP0135 to NEW for cmake >= 3.24
      - Enable DOWNLOAD_EXTRACT_TIMESTAMP with ExternalProject_Add + URL download method
    jrmadsen committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    ebd6ccd View commit details
    Browse the repository at this point in the history
  7. Update timemory submodule

    jrmadsen committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    7d86859 View commit details
    Browse the repository at this point in the history
  8. Update pybind11 submodule

    jrmadsen committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    6854670 View commit details
    Browse the repository at this point in the history
  9. Update pybind11 submodule

    jrmadsen committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    d6b1504 View commit details
    Browse the repository at this point in the history
  10. Update lib/core/rccl.hpp

    - include rccl.h only if OMNITRACE_USE_RCCL > 0
    jrmadsen committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    3069fe0 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    b72e08b View commit details
    Browse the repository at this point in the history
  12. Update lib/core/gpu.cpp

    - reintroduce some ppdefs
    jrmadsen committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    c11f44c View commit details
    Browse the repository at this point in the history
  13. Update lib/core/gpu.cpp

    - fix ifdef on OMNITRACE_HIP_VERSION
    jrmadsen committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    3c8245b View commit details
    Browse the repository at this point in the history
  14. Update lib/core/gpu.cpp

    - fix static assert for OMNITRACE_HIP_VERSION_MINOR when HIP version 4.x or older (unreliable minor versions)
    jrmadsen committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    bc427ce View commit details
    Browse the repository at this point in the history
  15. Update lib/core/gpu.cpp

    - fix ifdef on OMNITRACE_HIP_VERSION
    jrmadsen committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    f77901a View commit details
    Browse the repository at this point in the history
  16. Update lib/core/config.cpp

    - disable OMNITRACE_PERFETTO_COMBINE_TRACES by default
    jrmadsen committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    07fcecd View commit details
    Browse the repository at this point in the history
  17. Update lib/core/perfetto.cpp

    - if unable to open perfetto temp file, return the ReadTraceBlocking()
    jrmadsen committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    b734f37 View commit details
    Browse the repository at this point in the history
  18. Update lib/core/config.*

    - flush tmpfile before closing
    jrmadsen committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    4077790 View commit details
    Browse the repository at this point in the history