-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Roctracer flush activity fix + perfetto.cfg #317
Merged
Merged
Commits on Jan 9, 2024
-
- invoke roctracer_flush_activity() before disabling domains
Configuration menu - View commit details
-
Copy full SHA for 27c52e6 - Browse repository at this point
Copy the full SHA 27c52e6View commit details -
create comp::roctracer::flush()
- real issue was the global state when roctracer_flush_activity() was called
Configuration menu - View commit details
-
Copy full SHA for f67ac88 - Browse repository at this point
Copy the full SHA f67ac88View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5fa1a20 - Browse repository at this point
Copy the full SHA 5fa1a20View commit details -
Update lib/omnitrace/library/components/roctracer.hpp
- provide definition of comp::roctracer::flush when OMNITRACE_USE_ROCTRACER is not defined
Configuration menu - View commit details
-
Copy full SHA for 25274f7 - Browse repository at this point
Copy the full SHA 25274f7View commit details
Commits on Jan 10, 2024
-
- rename provided perfetto config file (omnitrace.cfg) to perfetto.cfg to avoid confusion
Configuration menu - View commit details
-
Copy full SHA for 899b484 - Browse repository at this point
Copy the full SHA 899b484View commit details -
- gpu.hpp: defines for OMNITRACE_USE_{HIP,ROCTRACER,ROCPROFILER,ROCM_SMI} - gpu.cpp - include core/hip_runtime.hpp - fix serialization of hipDeviceProp_t - add hip_runtime.hpp - ensure proper inclusion of hip_runtime.h - add rccl.hpp - ensure proper inclusion of rccl.h
Configuration menu - View commit details
-
Copy full SHA for 9f4b62c - Browse repository at this point
Copy the full SHA 9f4b62cView commit details -
- rcclp.cpp - update includes for rccl - roctracer.hpp - update includes for hip_runtime - components/comm_data.hpp - update includes for rccl - components/rcclp.hpp - update includes for rccl
Configuration menu - View commit details
-
Copy full SHA for 48a2256 - Browse repository at this point
Copy the full SHA 48a2256View commit details -
Update bin/omnitrace-avail/avail.cpp
- update includes for hip_runtime
Configuration menu - View commit details
-
Copy full SHA for 95e21aa - Browse repository at this point
Copy the full SHA 95e21aaView commit details -
Update examples/rccl/CMakeLists.txt
- fix find_package for rccl when CI enabled
Configuration menu - View commit details
-
Copy full SHA for 6776254 - Browse repository at this point
Copy the full SHA 6776254View commit details -
- set cmake policy CMP0135 to NEW for cmake >= 3.24 - Enable DOWNLOAD_EXTRACT_TIMESTAMP with ExternalProject_Add + URL download method
Configuration menu - View commit details
-
Copy full SHA for ebd6ccd - Browse repository at this point
Copy the full SHA ebd6ccdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7d86859 - Browse repository at this point
Copy the full SHA 7d86859View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6854670 - Browse repository at this point
Copy the full SHA 6854670View commit details -
Configuration menu - View commit details
-
Copy full SHA for d6b1504 - Browse repository at this point
Copy the full SHA d6b1504View commit details -
- include rccl.h only if OMNITRACE_USE_RCCL > 0
Configuration menu - View commit details
-
Copy full SHA for 3069fe0 - Browse repository at this point
Copy the full SHA 3069fe0View commit details -
Configuration menu - View commit details
-
Copy full SHA for b72e08b - Browse repository at this point
Copy the full SHA b72e08bView commit details -
Configuration menu - View commit details
-
Copy full SHA for c11f44c - Browse repository at this point
Copy the full SHA c11f44cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3c8245b - Browse repository at this point
Copy the full SHA 3c8245bView commit details -
- fix static assert for OMNITRACE_HIP_VERSION_MINOR when HIP version 4.x or older (unreliable minor versions)
Configuration menu - View commit details
-
Copy full SHA for bc427ce - Browse repository at this point
Copy the full SHA bc427ceView commit details -
Configuration menu - View commit details
-
Copy full SHA for f77901a - Browse repository at this point
Copy the full SHA f77901aView commit details -
- disable OMNITRACE_PERFETTO_COMBINE_TRACES by default
Configuration menu - View commit details
-
Copy full SHA for 07fcecd - Browse repository at this point
Copy the full SHA 07fcecdView commit details -
- if unable to open perfetto temp file, return the ReadTraceBlocking()
Configuration menu - View commit details
-
Copy full SHA for b734f37 - Browse repository at this point
Copy the full SHA b734f37View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4077790 - Browse repository at this point
Copy the full SHA 4077790View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.