Add Pivot AllToAll algorithm for Rome model #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yzygitzh
changed the title
wenkaidu
reviewed
Feb 18, 2022
wenkaidu
reviewed
Feb 18, 2022
wenkaidu
reviewed
Feb 18, 2022
wenkaidu
reviewed
Feb 18, 2022
wenkaidu
approved these changes
Feb 21, 2022
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Apr 22, 2022
use ncclAllToAll for rocm version > 5.0; ROCm/rccl#503 detail on ncclAllToAll: ROCm/rccl#503 @jithunnair-amd @amathews-amd Pull Request resolved: #75128 Approved by: https://github.com/wenkaidu, https://github.com/yzygitzh, https://github.com/seemethere
facebook-github-bot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Apr 26, 2022
Summary: use ncclAllToAll for rocm version > 5.0; ROCm/rccl#503 detail on ncclAllToAll: ROCm/rccl#503 jithunnair-amd amathews-amd Pull Request resolved: #75128 Approved by: https://github.com/wenkaidu, https://github.com/yzygitzh, https://github.com/seemethere Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/97fbe6f0a4d136d34fae851ffee823cb5e73bf71 Reviewed By: seemethere, osalpekar Differential Revision: D35874469 fbshipit-source-id: 653579837396cdc55bf3a7c2be0e893e16990c9a
pruthvistony
pushed a commit
to ROCm/pytorch
that referenced
this pull request
Apr 28, 2022
use ncclAllToAll for rocm version > 5.0; ROCm/rccl#503 detail on ncclAllToAll: ROCm/rccl#503 @jithunnair-amd @amathews-amd Pull Request resolved: pytorch#75128 Approved by: https://github.com/wenkaidu, https://github.com/yzygitzh, https://github.com/seemethere
pruthvistony
pushed a commit
to ROCm/pytorch
that referenced
this pull request
Apr 28, 2022
use ncclAllToAll for rocm version > 5.0; ROCm/rccl#503 detail on ncclAllToAll: ROCm/rccl#503 @jithunnair-amd @amathews-amd Pull Request resolved: pytorch#75128 Approved by: https://github.com/wenkaidu, https://github.com/yzygitzh, https://github.com/seemethere
pruthvistony
pushed a commit
to ROCm/pytorch
that referenced
this pull request
Apr 28, 2022
use ncclAllToAll for rocm version > 5.0; ROCm/rccl#503 detail on ncclAllToAll: ROCm/rccl#503 @jithunnair-amd @amathews-amd Pull Request resolved: pytorch#75128 Approved by: https://github.com/wenkaidu, https://github.com/yzygitzh, https://github.com/seemethere
jithunnair-amd
pushed a commit
to jithunnair-amd/pytorch
that referenced
this pull request
Sep 20, 2022
use ncclAllToAll for rocm version > 5.0; ROCm/rccl#503 detail on ncclAllToAll: ROCm/rccl#503 @jithunnair-amd @amathews-amd Pull Request resolved: pytorch#75128 Approved by: https://github.com/wenkaidu, https://github.com/yzygitzh, https://github.com/seemethere
jithunnair-amd
pushed a commit
to ROCm/pytorch
that referenced
this pull request
Sep 28, 2022
use ncclAllToAll for rocm version > 5.0; ROCm/rccl#503 detail on ncclAllToAll: ROCm/rccl#503 @jithunnair-amd @amathews-amd Pull Request resolved: pytorch#75128 Approved by: https://github.com/wenkaidu, https://github.com/yzygitzh, https://github.com/seemethere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new Pivot AlltoAll algorithm for Rome model. The algorithm is bandwidth-optimal for ring-based topologies, and brings ~70% speedup compared with direct P2P based AllToAll on rome_model_56.