Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ROCm] use ncclAllToAll for rocm #75128

Closed
wants to merge 3 commits into from
Closed

[ROCm] use ncclAllToAll for rocm #75128

wants to merge 3 commits into from

Conversation

KyleCZH
Copy link
Contributor

@KyleCZH KyleCZH commented Apr 1, 2022

use ncclAllToAll for rocm version > 5.0; ROCm/rccl#503

detail on ncclAllToAll:
ROCm/rccl#503

@jithunnair-amd @amathews-amd

@KyleCZH
[ROCm] use ncclAllToAll for rocm
274d3e6 
Signed-off-by: Kyle Chen <kylechen@amd.com>
@pytorch-bot pytorch-bot bot added the module: rocm AMD GPU support for Pytorch label Apr 1, 2022
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 1, 2022 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit ad30b1c (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@KyleCZH KyleCZH marked this pull request as ready for review April 5, 2022 22:03
@KyleCZH KyleCZH marked this pull request as draft April 8, 2022 06:26
@KyleCZH KyleCZH marked this pull request as ready for review April 8, 2022 22:00
@samdow samdow added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Apr 11, 2022
@kumpera
Copy link
Contributor

kumpera commented Apr 22, 2022

@pytorchbot merge this

@pytorchmergebot
Copy link
Collaborator

Merge failed due to Matched rule superuser, but it was not reviewed yet by any of:ymao1993,zzzwen,Gamrix,cherie11,dahsh, ...
Raised by https://github.com/pytorch/pytorch/actions/runs/2209245418

@seemethere
Copy link
Member

@pytorchbot merge this

@github-actions
Copy link

Hey @KyleCZH.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@kumpera kumpera added release notes: rocm mandatorylabel topic: improvements topic category labels Apr 22, 2022
facebook-github-bot pushed a commit that referenced this pull request Apr 26, 2022
@KyleCZH @facebook-github-bot
[ROCm] use ncclAllToAll for rocm (#75128)
ebe160f 
Summary:
use ncclAllToAll for rocm version > 5.0; ROCm/rccl#503

detail on ncclAllToAll:
ROCm/rccl#503

jithunnair-amd  amathews-amd

Pull Request resolved: #75128
Approved by: https://github.com/wenkaidu, https://github.com/yzygitzh, https://github.com/seemethere

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/97fbe6f0a4d136d34fae851ffee823cb5e73bf71

Reviewed By: seemethere, osalpekar

Differential Revision: D35874469

fbshipit-source-id: 653579837396cdc55bf3a7c2be0e893e16990c9a
pruthvistony pushed a commit to ROCm/pytorch that referenced this pull request Apr 28, 2022
@KyleCZH @pruthvistony
[ROCm] use ncclAllToAll for rocm
eb1ce9c 
use ncclAllToAll for rocm version > 5.0; ROCm/rccl#503

detail on ncclAllToAll:
ROCm/rccl#503

@jithunnair-amd  @amathews-amd
Pull Request resolved: pytorch#75128
Approved by: https://github.com/wenkaidu, https://github.com/yzygitzh, https://github.com/seemethere
pruthvistony pushed a commit to ROCm/pytorch that referenced this pull request Apr 28, 2022
@KyleCZH @pruthvistony
[ROCm] use ncclAllToAll for rocm
ed9b160 
use ncclAllToAll for rocm version > 5.0; ROCm/rccl#503

detail on ncclAllToAll:
ROCm/rccl#503

@jithunnair-amd  @amathews-amd
Pull Request resolved: pytorch#75128
Approved by: https://github.com/wenkaidu, https://github.com/yzygitzh, https://github.com/seemethere
pruthvistony pushed a commit to ROCm/pytorch that referenced this pull request Apr 28, 2022
@KyleCZH @pruthvistony
[ROCm] use ncclAllToAll for rocm
552dd71 
use ncclAllToAll for rocm version > 5.0; ROCm/rccl#503

detail on ncclAllToAll:
ROCm/rccl#503

@jithunnair-amd  @amathews-amd
Pull Request resolved: pytorch#75128
Approved by: https://github.com/wenkaidu, https://github.com/yzygitzh, https://github.com/seemethere
jithunnair-amd pushed a commit to jithunnair-amd/pytorch that referenced this pull request Sep 20, 2022
@KyleCZH @jithunnair-amd
[ROCm] use ncclAllToAll for rocm
3e8809a 
use ncclAllToAll for rocm version > 5.0; ROCm/rccl#503

detail on ncclAllToAll:
ROCm/rccl#503

@jithunnair-amd  @amathews-amd
Pull Request resolved: pytorch#75128
Approved by: https://github.com/wenkaidu, https://github.com/yzygitzh, https://github.com/seemethere
jithunnair-amd pushed a commit to ROCm/pytorch that referenced this pull request Sep 28, 2022
@KyleCZH @jithunnair-amd
[ROCm] use ncclAllToAll for rocm
fb7f729 
use ncclAllToAll for rocm version > 5.0; ROCm/rccl#503

detail on ncclAllToAll:
ROCm/rccl#503

@jithunnair-amd  @amathews-amd
Pull Request resolved: pytorch#75128
Approved by: https://github.com/wenkaidu, https://github.com/yzygitzh, https://github.com/seemethere
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seemethere seemethere seemethere approved these changes

@yzygitzh yzygitzh yzygitzh approved these changes

@wenkaidu wenkaidu wenkaidu approved these changes

Assignees
No one assigned
Labels
cla signed module: rocm AMD GPU support for Pytorch open source release notes: rocm mandatorylabel topic: improvements topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@KyleCZH @facebook-github-bot @kumpera @pytorchmergebot @seemethere @yzygitzh @wenkaidu @samdow @pytorchbot