Add flag to move libraries under project name #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahsan-ca
force-pushed
the
lib-under-project
branch
16 times, most recently
from
1536c0f
to
d186f0c
Compare
pfultz2
reviewed
May 15, 2024
| @@ -119,7 +119,7 @@ endfunction() | |||
| option(ROCM_SYMLINK_LIBS "Create backwards compatibility symlink for library files." ON) | |||
|
|
|||
| function(rocm_install_targets) | |||
| set(options) | |||
| set(options PRIVATE_LIB) | |||
There was a problem hiding this comment.
Can the word PRIVATE work here?
pfultz2
reviewed
May 15, 2024
| @@ -131,21 +131,51 @@ function(rocm_install_targets) | |||
| set(EXPORT_FILE ${PARSE_EXPORT}) | |||
| endif() | |||
|
|
|||
| set(PRIVATE_LIB OFF) | |||
There was a problem hiding this comment.
No need to make an intermediate variable, you can just check if(PARSE_PRIVATE) everywhere.
There was a problem hiding this comment.
I have made all the requested changes but I seem to be running into test failures now. Not sure if this change is causing the issue or is it something else that I am missing, but my changes are now breaking CI. I am looking into it.
There was a problem hiding this comment.
I have fixed the CI failures.
pfultz2
reviewed
May 15, 2024
test/libprivate/SimplePrivate.cpp
Outdated
| @@ -0,0 +1,7 @@ | |||
| /******************************************************************************* | |||
There was a problem hiding this comment.
Source files should be all lowercase.
pfultz2
reviewed
May 15, 2024
| #ifndef GUARD_SIMPLE_PRIVATE_H | ||
| #define GUARD_SIMPLE_PRIVATE_H | ||
|
|
||
| void simple-private(); |
There was a problem hiding this comment.
This should be simple_private as - is not valid symbol identifier.
There was a problem hiding this comment.
Thanks for catching that, I missed to change it here. Done.
ahsan-ca
force-pushed
the
lib-under-project
branch
2 times, most recently
from
2673381
to
055d869
Compare
ahsan-ca
force-pushed
the
lib-under-project
branch
2 times, most recently
from
258e82d
to
cbff664
Compare
ahsan-ca
force-pushed
the
lib-under-project
branch
from
b3a73a7
to
714b163
Compare
|
Libraries under Ubuntu: SLES: |
|
The CI failures seem unrelated to my changes. |
|
List of files from package... Ubuntu: dev: |
|
List of files from package... SLES: dev: |
|
Results of make install and make package are with the following changes to MIGraphX: |
pfultz2
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add flag to move libraries and include files under project name.