Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace GPU_LAUNCH_KERNEL with GpuLaunchKernel #439

Merged

Conversation

jerryyin
Copy link
Member

@jerryyin jerryyin commented May 6, 2019

Most work is done by following two commands:

  • find ./ -type f -exec sed -i -e 's/GPU_LAUNCH_KERNEL/GpuLaunchKernel/g' {} ;
  • find ./ -type f -exec sed -i -e 's/TF_CHECK_OK(CudaLaunchKernel/GpuLaunchKernel/g' {} ;

Test performed:
Local compile of rocm build succeed

tensorflow/core/util/gpu_launch_config.h Outdated Show resolved Hide resolved
@whchung whchung changed the title Replace GPU_LAUNCH_KERNLE with GpuLaunchKernel Replace GPU_LAUNCH_KERNEL with GpuLaunchKernel May 7, 2019
@jerryyin jerryyin force-pushed the develop-upstream-zyin-discard-GPU_LAUNCH_KERNEL branch 4 times, most recently from 0b8e0ae to 2185514 Compare May 7, 2019 16:27
Copy link
Collaborator

@whchung whchung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jerryyin jerryyin force-pushed the develop-upstream-zyin-discard-GPU_LAUNCH_KERNEL branch from 2185514 to d16b484 Compare May 7, 2019 17:24
@deven-amd
Copy link

LGTM for the first commit

@jerryyin jerryyin force-pushed the develop-upstream-zyin-discard-GPU_LAUNCH_KERNEL branch 3 times, most recently from 10803b7 to 108e018 Compare May 7, 2019 22:42
@whchung
Copy link
Collaborator

whchung commented May 8, 2019

@jerryyin CUDA path has build errors. It seems the very recent changes in #443 was't taken into consideration in the PR.

@jerryyin jerryyin force-pushed the develop-upstream-zyin-discard-GPU_LAUNCH_KERNEL branch from 108e018 to 8f17169 Compare May 8, 2019 01:59
@jerryyin
Copy link
Member Author

jerryyin commented May 8, 2019

@whchung You bet! Rebase timing can't be better, and git silently take all code update in #443 without any complains.

@whchung whchung merged commit 5cd505a into develop-upstream May 8, 2019
@whchung
Copy link
Collaborator

whchung commented May 8, 2019

@jerryyin just merged this PR. please amend upstream PR thanks.

@yxsamliu please check with hip-clang toolchain.

@jerryyin jerryyin deleted the develop-upstream-zyin-discard-GPU_LAUNCH_KERNEL branch December 20, 2019 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants