Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

see if gcov and clang versions match #150

Merged
merged 8 commits into from May 11, 2019
Merged

see if gcov and clang versions match #150

merged 8 commits into from May 11, 2019

Conversation

gonsie
Copy link
Member

@gonsie gonsie commented May 6, 2019

WIP

@gonsie gonsie changed the base branch from master to develop May 6, 2019 23:52
@gonsie gonsie marked this pull request as ready for review May 7, 2019 00:02
@gonsie
Copy link
Member Author

gonsie commented May 7, 2019

future note: draft PRs are not run through travis. This is due to "branches: only:" section in the .travis file. Active PRs that have a base of master or develop are tested.

That said, I don't really think that was the original intent behind the "branches: only:" statement. Instead, I think the intent was to only update the doxygen after a successful merge to master. This portion of the .travis.yml file should be re-evaluated.

@caitlinross
Copy link
Member

So looking into it, gcov comes with gcc (and I guess lcov is actually a GUI for gcov). Perhaps for that build where we do make coveralls, we should just switch to using gcc instead of clang? Then the versions should match.

As for the branches: only: in the .travis.yaml, we could remove that. Then we could do something like different build stages, where we have our testing stage and then another for updating doxygen. And then make the doxygen stage conditional on the branch being master.

@codecov
Copy link

codecov bot commented May 7, 2019

Codecov Report

❗ No coverage uploaded for pull request base (develop@2f10a73). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #150   +/-   ##
==========================================
  Coverage           ?   58.42%           
==========================================
  Files              ?       32           
  Lines              ?     3541           
  Branches           ?        0           
==========================================
  Hits               ?     2069           
  Misses             ?     1472           
  Partials           ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f10a73...bd2f0d9. Read the comment docs.

@gonsie
Copy link
Member Author

gonsie commented May 7, 2019

the cmake scripts which set up the coverage stuff is pretty brittle at the moment. There is a lot to do, but not worth it for this release. It works for now. Merging into develop should make the coverage report get better.

@gonsie gonsie mentioned this pull request May 7, 2019
5 tasks
@caitlinross caitlinross merged commit d8be7e4 into develop May 11, 2019
@caitlinross caitlinross deleted the gcov-test branch May 11, 2019 23:02
caitlinross added a commit that referenced this pull request May 16, 2019
* ROSS cleanup (#135)

This commit fixes warnings when building with -Wall and -Wextra.  In addition, removes old unused code related to prior pthread versions of ROSS as well as removing the ROSS_MEMORY related code, due to no longer being fully functional.

* fixing warnings when building with Wall, etc

* fixing warnings in buddy.c

* fixing warnings in the rest of ROSS core

* fixing warnings in instrumentation

* fixing warnings with phold

* fixing undefined reference causing linking error

* adding warning flags to Travis builds

* fixing some additional warnings that appear in release builds

* minor changes to travis builds

* removing old, unnecessary pthread related code

* fixing ifdefs for ROSS_MEMORY

* removing tw-memory related stuff for now

* removing some unused stuff and unnecessary function arguments

* lots of documentation for network-mpi and removing some unnecessary stuff

* keeping the ROSS models submodule from being used in Travis tests

* minor fix for C++ Travis build

* adding installing phold to bin

* adding some RPATH commands to CMakeLists.txt for Spack

* removed ROSS-Models and template model submodule

* update readme for submodule details

* rpath in pkg-config

* adding develop branch to Travis safelist

* simplifying the build of static or shared libraries (#147)

* Update to the way the build process grabs version number (#148)

* updating the way the version number is grabbed, so we can have the actual version and not the git commit

* fixing an error that caused coveralls to fail

* updating README and removing out-of-date README-vis (current info is on webpage)

* few more updates to README

* changing damaris submodule/directory to risa

* see if gcov and clang versions match (#150)

* see if gcov and clang versions match

* maybe we should be using lcov... since we apt-get it

* whitespace

* what version is llvm-cov?

* use llvm-cov

* llvm-cov gcov

* remove cov version checks

* removing ROSS_obj from Cmake build - no longer necessary with single library creation

* removing some files that are actually unnecessary for version numbers as well as having ROSS output both version number and commit, instead of just version
@gonsie gonsie mentioned this pull request Dec 2, 2019
gonsie added a commit that referenced this pull request Dec 2, 2019
Merge release-7.2.0:

* New default clock: get-time-of-day (#170)
* STime API (#159)
* Add ARMv7l arch support to ROSS (#155)
* Fix to generate covage stats (#150)
* changing damaris submodule/directory to risa
* Updated README
* Update to the way the build process grabs version number (#148)
* simplifying the build of static or shared libraries (#147)
* ROSS cleanup: -Wall, -Wextra, and more (#135)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants