-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Time API #159
Time API #159
Conversation
- gvt_print_interval (gvt/mpi_allreduce.h) - percent_complete (gvt/mpi_allreduce.h) - g_tw_ts_end - g_tw_lookahead - g_tw_min_detected_offset
3 API operations, implemented in #define - TW_STIME_DBL(x) : convert tw_stime to double - TW_STIME_CMP(x, y) : compare two tw_stime objects - TW_STIME_ADD(x, y) : add two tw_stime objects into a new object - TW_STIME_MAX : return a "max" tw_stime object (similar to DBL_MAX)
For real-time reporting... not based on cycle counts
Codecov Report
@@ Coverage Diff @@
## develop #159 +/- ##
===========================================
- Coverage 58.42% 58.17% -0.26%
===========================================
Files 32 32
Lines 3541 3558 +17
===========================================
+ Hits 2069 2070 +1
- Misses 1472 1488 +16
Continue to review full report at Codecov.
|
So I was wrong, this does represent an API change to ROSS model. I've renamed This API change means that we'd have do an 8.0 release. Alternatively, we could re-add TWOPT_STIME (as a deprecated option) for a 7.2 release... removing TWOPT_STIME in an eventual 8.0 release. |
Since this is an API change, I've created a CODES branch for the update. |
There is no functionality change, so no new unit tests are needed. Yet, coverage has increased 😄 |
Revert "tw-opts: removed STIME opt, replaced with DOUBLE" This reverts commit 61b6ef8.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just missing a few casts to double where instrumentation sampling functions are called (because of integer division).
I think once those few changes I pointed out are made, it's good to merge! |
Oh yeah and @gonsie in regards to CODES, it's actually been moved to GitHub so you may want to submit the PR there instead of Gitlab. |
thanks @caitlinross! I've updated the PR with your change requests. Please double check that I'm doing the double casting in the way you want. Then merge, or give me the go-ahead. thanks for the update on codes as well! I'll PR my update to them once we have a 7.2 release. |
Got it! For realz this time @caitlinross ! |
Merge release-7.2.0: * New default clock: get-time-of-day (#170) * STime API (#159) * Add ARMv7l arch support to ROSS (#155) * Fix to generate covage stats (#150) * changing damaris submodule/directory to risa * Updated README * Update to the way the build process grabs version number (#148) * simplifying the build of static or shared libraries (#147) * ROSS cleanup: -Wall, -Wextra, and more (#135)
This is a new API which allows for user defined
tw_stime
types. It is implemented through#define
macros, which should have minimal performance impact in the nominal case. Existing models do not need to change, unless they plan on supporting varioustw_stime
types.See the previous conversation in #157. This PR has
develop
as the base.If this merge represents a feature addition to ROSS, the following items must be completed before the branch will be merged:
Include a link to your blog post in the Pull Request.