Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New default clock: get-time-of-day #170

Merged
merged 5 commits into from
Oct 22, 2019
Merged

New default clock: get-time-of-day #170

merged 5 commits into from
Oct 22, 2019

Conversation

gonsie
Copy link
Member

@gonsie gonsie commented Oct 21, 2019

Redoing PR #144, but onto develop this time.

Added travis tests, so coverage should increase. I'll create a blog post before this is merged.

If this merge represents a feature addition to ROSS, the following items must be completed before the branch will be merged:

  • Document the feature on the blog (See the website Contributing guide).
    Include a link to your blog post in the Pull Request.
  • Builds should cleanly compile with -Wall and -Wextra.
  • One or more TravisCI tests should be created (and they should pass)
  • Through the TravisCI tests, coverage should increase
  • Test with CODES to ensure everything continues to work

@codecov
Copy link

codecov bot commented Oct 21, 2019

Codecov Report

Merging #170 into develop will increase coverage by 0.06%.
The diff coverage is 80%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #170      +/-   ##
===========================================
+ Coverage    58.17%   58.23%   +0.06%     
===========================================
  Files           32       33       +1     
  Lines         3558     3568      +10     
===========================================
+ Hits          2070     2078       +8     
- Misses        1488     1490       +2
Impacted Files Coverage Δ
core/clock/gtod.c 80% <80%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f21c68...9219e79. Read the comment docs.

@gonsie gonsie changed the title Gtod New default clock: get-time-of-day Oct 22, 2019
@gonsie
Copy link
Member Author

gonsie commented Oct 22, 2019

Blog post is up: https://ross-org.github.io/feature/gtod.html

@gonsie
Copy link
Member Author

gonsie commented Oct 22, 2019

tested with codes and all is good.

@gonsie gonsie merged commit dc562c5 into develop Oct 22, 2019
@gonsie gonsie deleted the gtod branch December 2, 2019 22:02
@gonsie gonsie mentioned this pull request Dec 2, 2019
gonsie added a commit that referenced this pull request Dec 2, 2019
Merge release-7.2.0:

* New default clock: get-time-of-day (#170)
* STime API (#159)
* Add ARMv7l arch support to ROSS (#155)
* Fix to generate covage stats (#150)
* changing damaris submodule/directory to risa
* Updated README
* Update to the way the build process grabs version number (#148)
* simplifying the build of static or shared libraries (#147)
* ROSS cleanup: -Wall, -Wextra, and more (#135)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant