Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(caa upload): Adapt to new Amazon page source code indentation #274

Merged
merged 1 commit into from
Dec 5, 2021

Conversation

kellnerd
Copy link
Collaborator

@kellnerd kellnerd commented Dec 5, 2021

The Amazon provider fails to extract the embedded JSON because it is no longer at the beginning of a new line but indented since a recent update.

Fixes #272.

@codecov
Copy link

codecov bot commented Dec 5, 2021

Codecov Report

Merging #274 (cd86f52) into main (3d09c41) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #274   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           40        40           
  Lines          886       886           
  Branches       159       159           
=========================================
  Hits           886       886           
Impacted Files Coverage Δ
.../mb_enhanced_cover_art_uploads/providers/amazon.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d09c41...cd86f52. Read the comment docs.

@kellnerd kellnerd merged commit 6cc7142 into main Dec 5, 2021
@kellnerd kellnerd deleted the amazon-regression branch December 5, 2021 12:16
github-actions bot added a commit that referenced this pull request Dec 5, 2021
fix(caa upload): Adapt to new Amazon page source code indentation (#274)
@github-actions
Copy link

github-actions bot commented Dec 5, 2021

🚀 Released 1 new userscript version(s):

  • mb_enhanced_cover_art_uploads 2021.12.5 in 4eb688b

@ROpdebee
Copy link
Owner

ROpdebee commented Dec 5, 2021

Thanks!

ROpdebee added a commit that referenced this pull request Dec 7, 2021
ROpdebee added a commit that referenced this pull request Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MB: Enhanced Cover Art Uploads Amazon problem
2 participants