feat(ecau): grab Apple Music original source images #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #327 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 41 41
Lines 894 899 +5
Branches 155 157 +2
=========================================
+ Hits 894 899 +5
Continue to review full report at Codecov.
|
ROpdebee
force-pushed
the
ecau-apple-music-source
branch
from
335d842
to
9fb9af4
Compare
ROpdebee
force-pushed
the
ecau-apple-music-source
branch
from
6905476
to
c023d50
Compare
|
/deploy-preview |
|
This PR changes 1 built userscript(s):
|
github-actions bot
added a commit
that referenced
this pull request
Dec 22, 2021
feat(ecau): grab Apple Music original source images (#327)
kellnerd
approved these changes
Dec 22, 2021
|
🚀 Released 1 new userscript version(s):
|
github-actions bot
added a commit
that referenced
this pull request
Dec 22, 2021
feat(ecau): grab Apple Music original source images (#327)
kellnerd
reviewed
Dec 22, 2021
ROpdebee
added a commit
that referenced
this pull request
Dec 22, 2021
As pointed out in #327 (comment), the URL will always be different because of an unconditional domain change. This changes the check to only compare URL pathnames to prevent problems due to domain names.
ROpdebee
added a commit
that referenced
this pull request
Dec 22, 2021
As pointed out in #327 (comment), the URL will always be different because of an unconditional domain change. This changes the check to only compare URL pathnames to prevent problems due to domain names.
ROpdebee
added a commit
that referenced
this pull request
Dec 22, 2021
As pointed out in #327 (comment), the URL will always be different because of an unconditional domain change. This changes the check to only compare URL pathnames to prevent problems due to domain names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #80 again.
Fast-tracked this because it's been bothering me for quite a while.