style: more linting and refactoring

[ROpdebee]

Okay this turned out to be much larger than I anticipated. Whoops.

Pretty much just installed some new plugins and fixed the issues I agreed with and disabled those that I disagree with or are otherwise useless.

My initial intention was to made some stylistic parts more consistent (like the empty line issues discussed in some other recent PR, forgot which), so I checked prettier. Not a big fan of its output and restrictive ruleset though, so I've decided against it for now. Still on the lookout for another formatter. Edit: Turns out ESLint could do this all along.

[ROpdebee]

/deploy-preview to ensure I didn't break anything

[codecov]

Codecov Report

Merging #464 (cddcb2b) into main (6c87f3f) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #464   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           46        46           
  Lines         1016      1008    -8     
  Branches       170       168    -2     
=========================================
- Hits          1016      1008    -8     

Impacted Files	Coverage Δ
src/lib/logging/logger.ts	100.00% <ø> (ø)
src/lib/util/xhr.ts	100.00% <ø> (ø)
src/lib/MB/EditNote.ts	100.00% <100.00%> (ø)
src/lib/MB/URLs.ts	100.00% <100.00%> (ø)
src/lib/logging/consoleSink.ts	100.00% <100.00%> (ø)
src/lib/util/blob.ts	100.00% <100.00%> (ø)
src/lib/util/domain_dispatch.ts	100.00% <100.00%> (ø)
src/mb_enhanced_cover_art_uploads/fetch.ts	100.00% <100.00%> (ø)
src/mb_enhanced_cover_art_uploads/form.ts	100.00% <100.00%> (ø)
src/mb_enhanced_cover_art_uploads/maximise.ts	100.00% <100.00%> (ø)
... and 25 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c87f3f...cddcb2b. Read the comment docs.

[github-actions]

This PR changes 1 built userscript(s):

• mb_enhanced_cover_art_uploads (install preview, changes: 6cb273a)

See all changes

[ROpdebee]

Manually did some E2E tests, mainly focusing on the parts with non-trivial changes, and everything seems to work properly, so the unit tests did their job well 🙂

[kellnerd]

The new rules look sensible to me and I did a quick test to ensure that they are also working in my setup (by manually reverting some of the changes).

[ROpdebee]

Thanks for the review @kellnerd. I'm going to hold off on merging these until caa dims is deployed though, otherwise I'd have to fix all these new warnings in that PR.

[ROpdebee]

Actually, scratch that. If we delay the merging of this PR, we'd have to relint every other future PR as well.

[github-actions]

🚀 Released 1 new userscript version(s):

• mb_enhanced_cover_art_uploads 2022.6.12 in 692d850