fix(ecau): don't require dimensions to load before inserting seed links on a-tisket #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently the `.dataset` attribute converts names to camelCase and they're not accessible under their original hyphenated name.
Codecov Report
@@ Coverage Diff @@
## main #476 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 46 46
Lines 1010 1010
Branches 168 168
=========================================
Hits 1010 1010 Continue to review full report at Codecov.
|
kellnerd
approved these changes
Jun 12, 2022
|
Although I said I'll rewrite the dimensions to use CAA Dims, it turns the |
|
🚀 Released 1 new userscript version(s):
|
github-actions bot
added a commit
that referenced
this pull request
Jun 13, 2022
fix(ecau): don't require dimensions to load before inserting seed links on a-tisket (#476)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #438. Also fixes a new issue introduced by #464 (seeding still worked, but it was using image links instead of release links).
If we merge #451 before this one, I'll also do the refactoring to use the new implementation here so we get a retry loop.