refactor(split links): rewrite "MB: Paste multiple external links" to TypeScript, fix shortcomings #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The script is fully broken at the moment, and there are multiple issues that have been open for a while. Addressing these issues will possibly require many changes, so we may as well rewrite to TS along the way. Still some type errors, will be fixed later.
Also rewrote pretty much the whole thing. Ref: metabrainz/musicbrainz-server#2544
ROpdebee
added
bug
Codecov Report
@@ Coverage Diff @@
## main #473 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 46 46
Lines 1008 1020 +12
Branches 168 170 +2
=========================================
+ Hits 1008 1020 +12
Continue to review full report at Codecov.
|
ROpdebee
force-pushed
the
ts-multi-external-links
branch
from
e056541
to
56311be
Compare
kellnerd
reviewed
Jun 12, 2022
Co-authored-by: David Kellner <52860029+kellnerd@users.noreply.github.com>
Thanks @kellnerd for the pointer.
kellnerd
approved these changes
Jun 12, 2022
github-actions bot
added a commit
that referenced
this pull request
Jun 12, 2022
refactor(split links): rewrite "MB: Paste multiple external links" to TypeScript, fix shortcomings (#473)
github-actions bot
added a commit
that referenced
this pull request
Jun 12, 2022
refactor(split links): rewrite "MB: Paste multiple external links" to TypeScript, fix shortcomings (#473)
github-actions bot
added a commit
that referenced
this pull request
Jun 12, 2022
refactor(split links): rewrite "MB: Paste multiple external links" to TypeScript, fix shortcomings (#473)
|
Why did it release new versions of ECAU and CAA Dims?? Edit Oh it's the input setter |
This was referenced Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another day, another TypeScript rewrite? This one became neglected ever since I first wrote it 馃槄
Fixes #471, root cause was metabrainz/musicbrainz-server#2544. Fix was easy enough, but I decided to get rid of the event listeners and instead wrap MB's methods to intercept the links and do all of the processing there. I also got rid of the
_reactInternalshack and just used normal event dispatching.Fixes #43 (finally!) by moving the checkbox outside of the table so we don't have to delete and re-insert it all of the time.
Fixes #42: Now runs on all external links editors that I know of (edit pages, create/add pages, and inside of the nested iframe dialogs, also on the relationship editor).
Tested manually, no unit tests for this since I think an E2E test would be much better suited (whenever those arrive 馃檮)
Now back to neglecting this script for another year 馃檪