Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distance screen improvements #17

Open
prichterich opened this issue Feb 10, 2023 · 6 comments
Open

Distance screen improvements #17

prichterich opened this issue Feb 10, 2023 · 6 comments

Comments

@prichterich
Copy link

I'm thinking about perhaps doing distance so I checked the distance screen for the first time. Several improvements are desirable:

  1. Always show distance in km (not meters). A precision of 0.1 is sufficient. In the test drive I did, the distance was shown in meters. After 10 km, the last digit overlaps with the "R" (for run distance).
  2. Replace run distance with battery percentage. Run distance rarely, if ever, makes sense when going for distance. But battery charge can be an issue when doing 10+ hour sessions. Seeing that battery gets low can be a reminder to take a break and charge the battery. Even a half hour charge at 0.5 A for 30 minutes can add a couple of hours of battery life. This is an issue for units with smaller batteries, but can also become an issue with large batteries when they get older. Here on Lake George, someone posts a 200+ km session almost every day.
  3. Consider a better layout, for example 2 lines with the same height, one for current speed and one for distance. Battery charge could be shown as an icon, like in older firmware versions, on the side. When doing distance, seeing total distance is just as important as current speed, and glasses or sunglasses may be quite dirty after a few hours on the water, making it hard to read smaller numbers.
@Freezer-SD
Copy link
Contributor

Freezer-SD commented Feb 10, 2023 via email

@prichterich
Copy link
Author

I noticed a bug in E_paper.cpp:
if(Ublox.total_distance/1000,0<9999)
Seems the line should read
if(Ublox.total_distance/1000.0<9999)
C always uses periods for the decimal point, not commas. Good example for mistakes that permissive languages like C or Perl allow that would be caught by the compiler in languages like Java, where using a comma here would be a syntax error.

@prichterich
Copy link
Author

I modified the distance code to show total distance and time. Here is what my code now looks like:

      if(field==5){
           display.setFont(&FreeSansBold12pt7b);
           display.print("D ");
           display.setFont(&FreeSansBold18pt7b);
           if(Ublox.total_distance/1000.0 < 999)
           display.print(Ublox.total_distance/1000,0);//Total distance in meter, als test run_distance
           else
           display.print(Ublox.total_distance/1000000,1);//Total distance in km, als test run_distance
           display.setCursor(offset+130,24);
           display.setFont(&FreeSansBold12pt7b);
           display.print(" ");
           display.setFont(&FreeSansBold18pt7b);
           display.print(time_now);
           }
        if(field==6){

There's enough space to show 4 digits before the comma.

@prichterich
Copy link
Author

The one thing that I'd like to see that's still missing for distance is a battery level indicator.

@RP6conrad
Copy link
Owner

RP6conrad commented Feb 18, 2023

This will be in the next update. I noticed that there was a bug in this comparison, but I did not know why. The bat indicator will be on the top right.

@RP6conrad
Copy link
Owner

Distance + bat level is now in SW 5.73

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants