Debugger: Simplify thread pause state change

RPCS3 · Oct 22, 2020 · 07be04a · 07be04a
1 parent 5430f03
commit 07be04a
Showing 1 changed file with 6 additions and 9 deletions.
diff --git a/rpcs3/rpcs3qt/debugger_frame.cpp b/rpcs3/rpcs3qt/debugger_frame.cpp
@@ -136,16 +136,13 @@ debugger_frame::debugger_frame(std::shared_ptr<gui_settings> settings, QWidget *
 	{
 		if (const auto cpu = this->cpu.lock())
 		{
-			if (m_btn_run->text() == RunString && cpu->state.test_and_reset(cpu_flag::dbg_pause))
-			{
-				if (!(cpu->state & (cpu_flag::dbg_pause + cpu_flag::dbg_global_pause)))
-				{
-					cpu->notify();
-				}
-			}
-			else
+			// Alter dbg_pause bit state (disable->enable, enable->disable)
+			auto old = cpu->state.xor_fetch(cpu_flag::dbg_pause);
+
+			// Notify only if no pause flags are set after this change
+			if (!(old & (cpu_flag::dbg_pause + cpu_flag::dbg_global_pause)))
 			{
-				cpu->state += cpu_flag::dbg_pause;
+				cpu->notify();
 			}
 		}
 		UpdateUI();