overlays: only log actual input loop errors

RPCS3 · Apr 20, 2022 · 11d2758 · 11d2758
1 parent 9f676d4
commit 11d2758
Show file tree

Hide file tree

Showing 5 changed files with 28 additions and 7 deletions.
diff --git a/rpcs3/Emu/RSX/Overlays/overlay_media_list_dialog.cpp b/rpcs3/Emu/RSX/Overlays/overlay_media_list_dialog.cpp
@@ -218,7 +218,10 @@ namespace rsx
 
 			if (const auto error = run_input_loop())
 			{
-				rsx_log.error("Media dialog input loop exited with error code=%d", error);
+				if (error != selection_code::canceled)
+				{
+					rsx_log.error("Media list dialog input loop exited with error code=%d", error);
+				}
 				return error;
 			}
 

diff --git a/rpcs3/Emu/RSX/Overlays/overlay_message_dialog.cpp b/rpcs3/Emu/RSX/Overlays/overlay_message_dialog.cpp
@@ -259,7 +259,10 @@ namespace rsx
 				{
 					if (const auto error = run_input_loop())
 					{
-						rsx_log.error("Dialog input loop exited with error code=%d", error);
+						if (error != selection_code::canceled)
+						{
+							rsx_log.error("Message dialog input loop exited with error code=%d", error);
+						}
 						return error;
 					}
 				}
@@ -296,7 +299,10 @@ namespace rsx
 
 							if (const auto error = run_input_loop())
 							{
-								rsx_log.error("Dialog input loop exited with error code=%d", error);
+								if (error != selection_code::canceled)
+								{
+									rsx_log.error("Message dialog input loop exited with error code=%d", error);
+								}
 							}
 						}
 						else

diff --git a/rpcs3/Emu/RSX/Overlays/overlay_osk.cpp b/rpcs3/Emu/RSX/Overlays/overlay_osk.cpp
@@ -1191,7 +1191,10 @@ namespace rsx
 
 				if (const auto error = run_input_loop())
 				{
-					rsx_log.error("Osk input loop exited with error code=%d", error);
+					if (error != selection_code::canceled)
+					{
+						rsx_log.error("Osk input loop exited with error code=%d", error);
+					}
 				}
 
 				thread_bits &= ~tbit;

diff --git a/rpcs3/Emu/RSX/Overlays/overlay_save_dialog.cpp b/rpcs3/Emu/RSX/Overlays/overlay_save_dialog.cpp
@@ -307,8 +307,14 @@ namespace rsx
 
 			visible = true;
 
-			if (const auto err = run_input_loop())
-				return err;
+			if (const auto error = run_input_loop())
+			{
+				if (error != selection_code::canceled)
+				{
+					rsx_log.error("Save dialog input loop exited with error code=%d", error);
+				}
+				return error;
+			}
 
 			if (return_code >= 0)
 			{

diff --git a/rpcs3/Emu/RSX/Overlays/overlay_user_list_dialog.cpp b/rpcs3/Emu/RSX/Overlays/overlay_user_list_dialog.cpp
@@ -259,7 +259,10 @@ namespace rsx
 
 				if (const auto error = run_input_loop())
 				{
-					rsx_log.error("Dialog input loop exited with error code=%d", error);
+					if (error != selection_code::canceled)
+					{
+						rsx_log.error("User list dialog input loop exited with error code=%d", error);
+					}
 				}
 
 				thread_bits &= ~tbit;