Fix Emu.Stop() with vulkan device enumeration hack

rpcs3/rpcs3qt/emu_settings.cpp

@@ -163,11 +163,11 @@ emu_settings::Render_Creator::Render_Creator()
 	static std::mutex mtx;
 	static std::condition_variable cond;
 	static bool thread_running = true;
-	static volatile bool device_found = false;
+	static bool device_found = false;
 
 	static QStringList compatible_gpus;
 
-	thread_ctrl::spawn("Vulkan device enumeration", [&]
+	std::thread* const enum_thread = new std::thread([&]
 	{
 		thread_ctrl::set_native_priority(-1);
 
@@ -189,7 +189,8 @@ emu_settings::Render_Creator::Render_Creator()
 				}
 			}
 		}
-		std::scoped_lock{mtx}, thread_running = false;
+
+		std::lock_guard{mtx}, thread_running = false;
 		cond.notify_all();
 	});
 
@@ -214,6 +215,7 @@ emu_settings::Render_Creator::Render_Creator()
 	}
 	else
 	{
+		enum_thread->join(); delete (enum_thread);
 		supportsVulkan = device_found;
 		vulkanAdapters = std::move(compatible_gpus);
 	}