Fix an emulator crash in Emulator::SaveSettings (#13567)

RPCS3 · Mar 21, 2023 · 7e6cc02 · 7e6cc02
1 parent 7000ef4
commit 7e6cc02
Showing 1 changed file with 10 additions and 3 deletions.
diff --git a/rpcs3/Emu/System.cpp b/rpcs3/Emu/System.cpp
@@ -3356,10 +3356,17 @@ void Emulator::SaveSettings(const std::string& settings, const std::string& titl
 
 	// Save config atomically
 	fs::pending_file temp(config_name);
-	temp.file.write(settings.c_str(), settings.size());
-	if (!temp.commit())
+	if (!temp.file)
 	{
-		sys_log.error("Could not save config to %s (error=%s)", config_name, fs::g_tls_error);
+		sys_log.error("Could not save config to %s (failed to create temporary file) (error=%s)", config_name, fs::g_tls_error);
+	}
+	else
+	{
+		temp.file.write(settings.c_str(), settings.size());
+		if (!temp.commit())
+		{
+			sys_log.error("Could not save config to %s (failed to commit) (error=%s)", config_name, fs::g_tls_error);
+		}
 	}
 
 	// Check if the running config/title is the same as the edited config/title.