[BLUS30115] Condemned 2: Memory corruption crash

[Realmantik]

This game still suffers from some problems with graphics and compiling shaders. I found new bug.

RPCS3.log.gz

[kd-11]

How reproducible is the crash? Does it happen each time at the same place? There is a lot of missing information here.

[Realmantik]

Today I changed some settings and not cleaned caches. I got some new fatal errors. I will try again with clear caches

• Thread terminated due to fatal error: Unknown register name: unk
  (in file D:\a\1\s\rpcs3\Emu\RSX\VK\VKCommonDecompiler.cpp:155[:23], in function get_varying_register_location)

• Thread terminated due to fatal error: Failed to compile fragment shader
  (in file D:\a\1\s\rpcs3\Emu\RSX\VK\VKProgramPipeline.cpp:28[:25], in function compile) (e=0x000000b7[183])
  RPCS3.log.zip
  shaderlog.zip

What information can I provide?

[kd-11]

All that stuff with unk usually points to a corrupted shader. This can happen in-game or during cache save/load. Try with a clean shader cache.
As for information, we need to know which shader triggers the crash, although from the above logs I can already see its not really the decompiler's fault, it was just served corrupted input.
The most important information here is how to trigger the shader corruption, if it happens on a specific level or doing a specific action causes it, etc. Basically - how can I get the same results on my end without using a shader cache.

[Realmantik]

I cannot reproduce the bug and new fragment shader improvements does not solve problems with graphics. But I found another bug in shaders. If I use Shader Interpreter then shadow of main character is broken.

BLUS30115_20210826202817_capture.zip

Shader Interpreter

Default Settings

[kd-11]

Shader interpreter is a debugging tool really, it is not meant to give 100% accurate graphics, it is there to render something close enough while the real shaders compile. I recommend using 'async + interpreter' if you intend to use it.

[kd-11]

We have "atomic FIFO mode" and "accurate RSX reservations" now in the advanced tab, the corrupted shaders shouldn't be an issue anymore. The remaining graphics glitching (excluding shader interpreter) is fixed by #12762.

[kd-11]

Closing, let's track in #5495